- Wine-GitLab - list.winehq.org

Re: [PATCH v12 0/9] MR1297: gdiplus: Add CustomLineCap implementation (including displaying).
by Esme Povirk (＠madewokherd) Nov. 21, 2022

Nov. 21, 2022

On Wed Nov 9 18:25:51 2022 +0000, Bartosz Kosiorek wrote: > changed this line in [version 5 of the diff](/wine/wine/-/merge_requests/1297/diffs?diff_id=17873&start_sha=ec560a173011779aa36bdb3d54e0bd805a70a729#708701348c59d29ebde2b9d5cd4724966113ebf7_308_308) I'm going to resolve this as it's only an explanation of the change and not a problem with it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1297#note_16779

1 0

Re: [PATCH v12 0/9] MR1297: gdiplus: Add CustomLineCap implementation (including displaying).
by Esme Povirk (＠madewokherd) Nov. 21, 2022

Nov. 21, 2022

Esme Povirk (@madewokherd) commented about dlls/gdiplus/graphicspath.c: > + widen_closed_figure(tmp_points, 0, custom->pathdata.Count - 1, pen, pen_width, last_point); > + else > + widen_open_figure(tmp_points, 0, custom->pathdata.Count - 1, pen, pen_width, LineCapFlat, LineCapFlat, last_point); > + } > + else > + { > + for (INT i = 0; i < custom->pathdata.Count; i++) > + { > + // rotation of CustomCap according to line > + perp_dx = custom->pathdata.Points[i].X * cosa + (custom->pathdata.Points[i].Y - 1.0) * sina; > + perp_dy = custom->pathdata.Points[i].X * sina - (custom->pathdata.Points[i].Y - 1.0) * cosa; > + *last_point = add_path_list_node(*last_point, posx + perp_dx, > + posy + perp_dy, custom->pathdata.Types[i]); > + } > + } > + // FIXME: The line should be shorter, and it should ends up when Arrow/Cap is started draw This comment makes things more confusing, I think. I'd suggest something like `FIXME: The line should be adjusted by the inset value of the custom cap.`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1297#note_16777

1 0

[PATCH v2 0/5] MR1472: opengl32: Complete wow64 thunks implementation.
by Rémi Bernon Nov. 21, 2022

Nov. 21, 2022

There's a few missing thunks for some non-standard extension functions, but that probably doesn't matter. -- v2: opengl32: Use the +opengl debug channel everywhere. opengl32: Cast wow64 pointers in glGet(VertexAttrib)Pointerv. opengl32: Implement wow64 thunks for glMapBuffer (et al.). opengl32: Use manual win32 thunks for glMapBuffer (et al.). opengl32: Implement wow64 thunk for glGetString (et al.). https://gitlab.winehq.org/wine/wine/-/merge_requests/1472

2 7

[PATCH v2 0/13] MR1447: mshtml: Implement performance.timing timestamps properly.
by Gabriel Ivăncescu Nov. 21, 2022

Nov. 21, 2022

-- v2: mshtml: Implement performance.timing.msFirstPaint. mshtml: Implement performance.timing.loadEventStart & loadEventEnd. mshtml: Get rid of useless window check. mshtml: Implement performance.timing.domContentLoadedEventStart & End. mshtml: Implement performance.timing.domComplete. mshtml: Implement performance.timing.domInteractive. mshtml: Implement performance.timing.domLoading. mshtml: Implement performance.timing.responseStart & responseEnd. mshtml: Implement the remaining pre-response performance.timing props. mshtml: Implement performance.timing.unloadEventStart & unloadEventEnd. mshtml: Implement performance.timing.redirectStart. mshtml: Implement performance.timing.navigationStart. mshtml: Store link to the inner window in HTMLPerformance. https://gitlab.winehq.org/wine/wine/-/merge_requests/1447

3 21

[PATCH v2 0/1] MR1455: dinput: Wait on event instead of thread on stop
by Fabian Maurer (＠DarkShadow44) Nov. 21, 2022

Nov. 21, 2022

Since we stop the thread in DllMain, we always haev the loaderlock. Thread shutdown also requires the loader lock, so we will always time out So just wait until all cleanup is done, the thread itself can exit later Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52314 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- v2: dinput: Wait on event instead of thread on stop https://gitlab.winehq.org/wine/wine/-/merge_requests/1455

4 7

[PATCH v3 0/1] MR1449: msado15: Avoid uninitialized variable warning in fields_get_Item
by Gerald Pfeifer (＠gerald) Nov. 21, 2022

Nov. 21, 2022

This avoids the following warning by GCC 13: dlls/msado15/recordset.c:790:32: warning: 'i' may be used uninitialized -- v3: msado15: Avoid uninitialized variable warning in fields_get_Item https://gitlab.winehq.org/wine/wine/-/merge_requests/1449

4 3

[PATCH v4 0/3] MR1473: Support unmangling C++11 function's reference qualifiers.
by eric pouech (＠epo) Nov. 21, 2022

Nov. 21, 2022

-- v4: ucrtbase: Handle undecoration of function's reference qualifiers (C++11). msvcrt: Rename modifier into qualifier. ucrtbase: Extend ucrtbase's undname tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1473

3 4

[PATCH v2 0/3] MR1473: Support unmangling C++11 function's reference qualifiers.
by eric pouech (＠epo) Nov. 21, 2022

Nov. 21, 2022

-- v2: ucrtbase: Handle undecoration of function's reference qualifiers (C++11). msvcrt: Rename modifier into qualifier. ucrtbase: Extend ucrtbase's undname tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1473

3 5

[PATCH 0/3] MR1461: ieframe: Remove function heap_strdupW.
by Alex Henrie (＠alexhenrie) Nov. 21, 2022

Nov. 21, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1461

4 7

[PATCH 0/3] MR1473: Support unmangling C++11 function's reference qualifiers.
by eric pouech (＠epo) Nov. 21, 2022

Nov. 21, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1473

3 4