- Wine-GitLab - list.winehq.org

Re: [PATCH v12 0/6] MR42: vkd3d-shader/hlsl: Some fixes. - approved
by Alexandre Julliard (＠julliard) Nov. 10, 2022

Nov. 10, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/42

1 0

[PATCH 0/1] MR1327: d2d1/tests: Use correct flags constants with D3D11CreateDevice().
by Nikolay Sivov (＠nsivov) Nov. 10, 2022

Nov. 10, 2022

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1327

3 2

[PATCH v2 0/1] MR1250: Draft: win32u: Initialize the server's cursor position from the user driver's.
by Tim Clem (＠tclem) Nov. 10, 2022

Nov. 10, 2022

The server's idea of the cursor position is never really initialized. Normally that's not a problem, since the first mouse movement and a number of other X events will update it. But in the case where the user never moves the mouse, it can remain out of sync. That manifests as `GetCursorPos` bouncing between the server's incorrect value and the real one from the user driver, depending on the age of the position on the server. I've marked this as a draft for two reasons: 1. I don't quite know where this belongs. We want to do it early in the lifespan of a user driver but after there's a desktop, so I've put it behind a `pthread_once` called from `get_desktop_window`. 2. I'm calling `NtUserSetCursorPos` to update the server, rather than a direct `set_cursor` request, because it contains some DPI logic. That has the side effect of potentially warping the cursor. That's not desirable or necessary, but it shouldn't be a problem. It's easily factored around if we want to avoid it. Any guidance would be greatly appreciated! -- v2: win32u: Initialize the server's cursor position from the user driver's. https://gitlab.winehq.org/wine/wine/-/merge_requests/1250

3 7

Re: [PATCH v2 0/1] MR1304: light.msstyles: Add nonclient metrics.
by Rémi Bernon Nov. 10, 2022

Nov. 10, 2022

On Thu Nov 10 16:26:09 2022 +0000, Zhiyi Zhang wrote: > https://gitlab.winehq.org/epo/wine/-/jobs/4880 succeeds It's for a MR that hasn't been rebased on top of latest HEAD and doesn't contain this change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1304#note_13956

1 0

Re: [PATCH v2 0/1] MR1304: light.msstyles: Add nonclient metrics.
by Zhiyi Zhang (＠zhiyi) Nov. 10, 2022

Nov. 10, 2022

On Thu Nov 10 15:24:19 2022 +0000, Zhiyi Zhang wrote: > Tahoma is available so it's probably not that. > In the last comment, I mentioned there are no failures I meant no msg.c > failures. On second look, I can reliably reproduce those win.c failures > on FVWM, going as far back as wine-7.10. https://gitlab.winehq.org/epo/wine/-/jobs/4880 succeeds -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1304#note_13954

1 0

Re: [PATCH v2 0/1] MR1304: light.msstyles: Add nonclient metrics.
by Zhiyi Zhang (＠zhiyi) Nov. 10, 2022

Nov. 10, 2022

On Thu Nov 10 14:20:00 2022 +0000, Rémi Bernon wrote: > Reverting that single commit fixes the Gitlab pipeline, see > https://gitlab.winehq.org/rbernon/wine/-/pipelines/4066 vs > https://gitlab.winehq.org/rbernon/wine/-/pipelines/4064. It's perhaps > something with missing fonts? Tahoma is available so it's probably not that. In the last comment, I mentioned there are no failures I meant no msg.c failures. On second look, I can reliably reproduce those win.c failures on FVWM, going as far back as wine-7.10. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1304#note_13949

1 0

[PATCH v2 0/7] MR1312: ntdll: Implement heap user flags and fix GlobalHandle / LocalHandle with heap pointers.
by Rémi Bernon Nov. 10, 2022

Nov. 10, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53741 -- v2: ntdll: Implement RtlSetUserFlagsHeap. ntdll: Check block user flags in RtlGetUserInfoHeap. ntdll: Check block user flags in RtlSetUserValueHeap. ntdll: Store the user flags in the heap block flags. ntdll: Introduce a new heap block_set_flags helper. kernel32/tests: Test (Global|Local)Handle with heap allocated pointers. kernel32/tests: Test more Global/Local functions with invalid pointers. https://gitlab.winehq.org/wine/wine/-/merge_requests/1312

2 9

[PATCH 0/3] MR1322: opengl32: Convert to PE.
by Rémi Bernon Nov. 10, 2022

Nov. 10, 2022

Performance hit measured on a few games (with esync and wined3d), CPU% is the time spent in the syscall dispatcher as measured with `perf top -K` while the game is running, the measured scene is usually right after starting a new game: * Brink (32-bit, GL, id Tech 4): 550 fps, 3% CPU -> 480 fps, 12% CPU * Shadow Warrior 2 (64-bit, d3d11): 75 fps, 2% CPU -> 50 fps, 20% CPU * Hat in Time (64-bit, d3d9, UE3): 220 fps, 5% CPU -> 215 fps, 10% CPU * Control (64-bit, d3d11): 25 fps, 0% CPU -> 25 fps, 3% CPU * Obduction (64-bit, d3d11, UE4): 85 fps, 30% CPU -> 80 fps, 30% CPU -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1322

3 8

Re: [PATCH v2 0/1] MR1304: light.msstyles: Add nonclient metrics.
by Rémi Bernon Nov. 10, 2022

Nov. 10, 2022

On Thu Nov 10 14:15:17 2022 +0000, Zhiyi Zhang wrote: > It's hard to tell if it's caused by this commit. I can not reproduce > this with Ubuntu 22.10 GNOME 43. Then I switched to FVWM and > successfully reproduced the failures. However, just as when I tried to > bisect, all the failures are gone. I also tried to create a new prefix > with f7e1bb9(right before this commit), then apply this patch and rerun > the tests, but still no failures. After applying the patch, I manually > copied the new light.msstyles to the old prefix, no failures. Then > toggling the theming status or recreating the prefix with 9f3138b can > not reproduce those failures either. > Those failures also look unrelated to the theming changes. Reverting that single commit fixes the Gitlab pipeline, see https://gitlab.winehq.org/rbernon/wine/-/pipelines/4066 vs https://gitlab.winehq.org/rbernon/wine/-/pipelines/4064. It's perhaps something with missing fonts? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1304#note_13944

1 0

Re: [PATCH v2 0/1] MR1304: light.msstyles: Add nonclient metrics.
by Zhiyi Zhang (＠zhiyi) Nov. 10, 2022

Nov. 10, 2022

On Thu Nov 10 14:15:18 2022 +0000, Rémi Bernon wrote: > I believe this broke Gitlab CI, this is the only pipeline that failed > from yesterday, in user32, and it now fails with all MRs. It's hard to tell if it's caused by this commit. I can not reproduce this with Ubuntu 22.10 GNOME 43. Then I switched to FVWM and successfully reproduced the failures. However, just as when I tried to bisect, all the failures are gone. I also tried to create a new prefix with f7e1bb9(right before this commit), then apply this patch and rerun the tests, but still no failures. After applying the patch, I manually copied the new light.msstyles to the old prefix, no failures. Then toggling the theming status or recreating the prefix with 9f3138b can not reproduce those failures either. Those failures also look unrelated to the theming changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1304#note_13939

1 0