- Wine-GitLab - list.winehq.org

[PATCH 0/1] MR462: secur32: Fix GnuTLS system priority file override.
by Hans Leidekker (＠hans) July 14, 2022

July 14, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53344 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/462

2 1

Re: [PATCH 0/1] MR363: user32/tests: Test for window exposure behaviours.
by Jinoh Kang (＠iamahuman) July 14, 2022

July 14, 2022

Jinoh Kang (@iamahuman) commented about dlls/user32/tests/msg.c: > DeleteObject( hrgn2 ); > } > > +static void visualize_region_differences( HWND hwnd, HWND hother, HRGN hrgn_expect, HRGN hrgn_actual ) I included this function since it was really helpful for me while testing debugging the implementation--it eliminates the need to interpret the rectangle list manually. I can remove this if it clutters the test, though. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/363#note_4317

1 0

Re: [PATCH 0/2] MR314: ntdll/tests: Preserve EFLAGS across syscall on x64.
by Jinoh Kang (＠iamahuman) July 14, 2022

July 14, 2022

Superseded by MR !282 (probably). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/314#note_4315

1 0

Re: [PATCH 0/2] MR314: ntdll/tests: Preserve EFLAGS across syscall on x64. - closed
by Jinoh Kang (＠iamahuman) July 14, 2022

July 14, 2022

This merge request was closed by Jinoh Kang. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/314

1 0

Re: [PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Jinoh Kang (＠iamahuman) July 14, 2022

July 14, 2022

Jinoh Kang (@iamahuman) commented about server/async.c: > return woken; > } > > +static int cancel_blocking( struct process *process, struct thread *thread, client_ptr_t iosb ) > +{ > + struct async *async; > + int woken = 0; > + > +restart: > + LIST_FOR_EACH_ENTRY( async, &process->asyncs, struct async, process_entry ) > + { > + if (async->terminated || async->canceled) continue; There is a pre-existing bug where cancellation requests are ignored for alerted asyncs (i.e. async instances that are not actually completed and can go back from the "terminated" state to the pending state). Perhaps it's worth addressing that bug first? https://www.winehq.org/pipermail/wine-devel/2022-March/210053.html -- https://gitlab.winehq.org/wine/wine/-/merge_requests/47#note_3836

2 1

[PATCH 0/1] MR459: maintainers: Add trailing slashes to directories.
by Jeremy White (＠jwhite) July 14, 2022

July 14, 2022

The gitlab scripts operate without access to the wine tree. Requiring a trailing slash on patterns simplifies the logic to automatically assign reviewers to MRs. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/459

2 1

[PATCH v3 0/2] MR419: win32u/window: Ignore SetWindowPos() for message-only windows.
by Giovanni Mascellani (＠giomasce) July 14, 2022

July 14, 2022

-- v3: win32u/window: Ignore changing WS_EX_TOPMOST for message-only windows. user32/tests: Check that message-only windows ignore WS_EX_TOPMOST. https://gitlab.winehq.org/wine/wine/-/merge_requests/419

2 2

[PATCH 0/1] MR458: winevulkan: Update to VK spec version 1.3.221.
by Georg Lehmann (＠DadSchoorse) July 14, 2022

July 14, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/458

2 1

Re: [PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Jinoh Kang (＠iamahuman) July 14, 2022

July 14, 2022

On Thu Jul 14 06:48:37 2022 +0000, Daniel Lehman wrote: > in the exchange, it sounded like you had or were working on a fix. were > you asking me to fix it or wait for your fix? Well, it was actually more of a question than a suggestion. I just wondered if it would be a good idea to get I/O cancellation right first, lest rolling in another cancellation function would result in some unknown regression due to falsely indicated success from that function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/47#note_4299

1 0

[PATCH v5 0/1] MR398: xactengine3_7/tests: Test notifications when loading a wave bank.
by Giovanni Mascellani (＠giomasce) July 14, 2022

July 14, 2022

"The King of Fighters '98 Ultimate Match Final Edition" depends on this behavior. At least, the build I have is; it seems other builds are not. Signed-off-by: Giovanni Mascellani <gmascellani(a)codeweavers.com> -- v5: xactengine3_7/tests: Test notifications when loading a wave bank. https://gitlab.winehq.org/wine/wine/-/merge_requests/398

3 2