- Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Daniel Lehman (＠dlehman25) July 11, 2022

July 11, 2022

On Mon Jul 11 15:14:43 2022 +0000, Jinoh Kang wrote: > How about the following race-free approach? > ```suggestion:-0+0 > /* wait for I/O to start, which transitions the pipe handle from > signaled to nonsignaled state. */ > while ((wait_status = WaitForSingleObject(pipe, 0)) == > WAIT_OBJECT_0) Sleep(1); > ok(wait_status == WAIT_TIMEOUT, "WaitForSingleObject returned %lu > (error %lu)\n", wait_status, GetLastError()); > ``` > Ditto for other places. i had copied the `Sleep(100)` from one of the sync.c tests, i think. but if it makes the test less flaky, i'll take it. thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/47#note_3919

1 0

[PATCH v2 0/4] MR428: wineusb.sys: PE conversion
by Zebediah Figura (＠zfigura) July 11, 2022

July 11, 2022

-- v2: wineusb.sys: Move the event queue and device list to the Unix library. https://gitlab.winehq.org/wine/wine/-/merge_requests/428

2 4

Re: [PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Daniel Lehman (＠dlehman25) July 11, 2022

July 11, 2022

On Mon Jul 11 15:14:45 2022 +0000, Jinoh Kang wrote: > Per Wine code style, you should omit the second space in `&io ) )`. > ```suggestion:-0+0 > return set_ntstatus( NtCancelSynchronousIoFile( thread, NULL, &io )); > ``` the file has a mix of styles. it does look from a skim like most are without the space, but i think i copied from CancelIo and CancelIoEx right above it, and they both have the space. never quite sure what to do in those cases, but i can remove it -- https://gitlab.winehq.org/wine/wine/-/merge_requests/47#note_3917

1 0

Re: [PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Daniel Lehman (＠dlehman25) July 11, 2022

July 11, 2022

> Wait, what's partial about it? i don't handle the 2nd argument, but it doesn't seem to be used for what i need, though. i can implement the higher level kernel32 call without it what about something like this, copied from NtUnlockFile: ` TRACE( "(%p %p %p)\n", handle, io, io_status ); if (io) FIXME("Unimplemented yet parameter\n"); ` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/47#note_3914

2 1

Re: [PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Daniel Lehman (＠dlehman25) July 11, 2022

July 11, 2022

On Mon Jul 11 15:14:44 2022 +0000, Jinoh Kang wrote: > Maybe you forgot to remove the extraneous parentheses? you mean the parentheses around `(async->thread == thread)`? i can remove those -- https://gitlab.winehq.org/wine/wine/-/merge_requests/47#note_3913

1 0

[PATCH 0/4] MR428: wineusb.sys: PE conversion
by Zebediah Figura (＠zfigura) July 11, 2022

July 11, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/428

2 4

[PATCH 0/1] MR427: ntdll: Preserve rbx register when calling DLL entry point on x64.
by Paul Gofman (＠gofman) July 11, 2022

July 11, 2022

Assassin's Creed Origins clobbers rbx in its main module (second of three) TLS callbacks. That is apparent right in the beginning of the TLS callback disassembly when rbx is set to '4' unconditionally without any prior save. That leads to a fault in call_tls_callbacks() which is still in __TRY block and gets handled. However the third TLS callback is not executed and that leads to intermittent hangs later on. It is rather involved to make a TLS callback test in Wine testsuite as there is no portable way to generate a custom TLS callback. I've made a test program (based on the example here: https://lallouslab.net/2017/05/30/using-cc-tls-callbacks-in-visual-studio-w…) and compiled it with MSVC. The source code is here: https://gist.github.com/gofman/3287a953bcab3a5c888a8d494461cb8a. The program calls all the callbacks on Windows 10 here. There is also a similar wrapper already there for i386 on another occasion. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/427

2 1

[PATCH 0/2] MR426: ddraw/tests: Build without -DWINE_NO_LONG_TYPES.
by Zebediah Figura (＠zfigura) July 11, 2022

July 11, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/426

2 2

[PATCH 0/1] MR425: ntdll: Do not use find_subheap() to find the subheap corresponding to an uncommitted region.
by Zebediah Figura (＠zfigura) July 11, 2022

July 11, 2022

The commit end of a subheap may be equal to the beginning of another subheap, in which case find_subheap() will return that one, and we may effectively skip backwards in the subheap list. --- There may be a more architecturally palatable way to solve this problem, but hopefully this is enough to at least demonstrate it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/425

2 1

Re: [PATCH v4 0/1] MR423: ieframe fix - approved
by Alexandre Julliard (＠julliard) July 11, 2022

July 11, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/423

1 0