- Wine-GitLab - list.winehq.org

[PATCH 0/4] MR9584: win32u: Update client surfaces starting from toplevel window.
by Rémi Bernon Nov. 25, 2025

Nov. 25, 2025

In apply_window_pos, to notify any parent or children and let them make the necessary changes for offscreen rendering. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9584

1 4

[PATCH v4 0/6] MR9371: kernel32: Implement TH32CS_SNAPMODULE32 support for CreateToolhelp32Snapshot.
by Yuxuan Shui (＠yshui) Nov. 25, 2025

Nov. 25, 2025

Intention is to use `CreateToolhelp32Snapshot` in `dbghelp.dll: EnumerateLoadedModulesW64`. Right now we can't because `CreateToolhelp32Snapshot` can't capture 32bit modules in wow64 processes, which is needed to support `SYMOPT_INCLUDE_32BIT_MODULES`. The advantage of using `CreateToolhelp32Snapshot` in mainly performance. Right now `EnumerateLoadedModulesW64` is `O(n^2)`, because of each module it calls `GetModuleInformation` which is itself `O(n)` w.r.t. number of modules. Whereas with `CreateToolhelp32Snapshot` there is no need for `GetModuleInformation`, thus reduce the complexity to just `O(n)`. * * * P.S. I am also uncomfortable with the amount of similar code between `CreateToolhelp32Snapshot` and `EnumProcessModulesEx`. Can something be done here? -- v4: kernel32: Implement TH32CS_SNAPMODULE32 support for CreateToolhelp32Snapshot. kernel32: Use GetCurrentProcess() handle in CreateToolheap32Snapshot if possible. kernel32: Test CreateToolhelp32Snapshot with TH32CS_SNAPMODULE32. include: Add TH32CS_SNAPMODULE32. kernel32/tests: Fix CreateToolhelp32Snapshot failure check. kernel32: Fix unsupported flags check in CreateToolhelp32Snapshot. https://gitlab.winehq.org/wine/wine/-/merge_requests/9371

3 17

[PATCH 0/1] MR9577: cmd: Dynamically allocate real_path in WCMD_list_directory (ASan).
by Bernhard Übelacker Nov. 25, 2025

Nov. 25, 2025

By accident I had still some left-over directories from some test run, and tried a recursive dir in the wineprefix. That led to the ASan report below. [Testbot run with this patch](https://testbot.winehq.org/JobDetails.pl?Key=161037) <details> <summary>ASan report with gdb session</summary> ``` $ wine cmd /K "cd /d c:" c:\>dir c:\tmp.txt /s Datenträger in Laufwerk c hat keine Bezeichnung. Datenträgernummer ist 4300-0000 Directory of c: 16.10.2025 22:48 5,925,244 tmp.txt 1 file 5,925,244 bytes ================================================================= ==520==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7ffffe1ddea8 at pc 0x00014001a9e9 bp 0x7ffffe1dd270 sp 0x7ffffe1dd2b8 WRITE of size 2 at 0x7ffffe1ddea8 thread T0 #0 0x00014001a9e8 in lstrcatW .../wine/include/winbase.h:2615 #1 0x00014001b8c9 in WCMD_list_directory .../wine/programs/cmd/directory.c:276 #2 0x00014001c7e3 in WCMD_list_directory .../wine/programs/cmd/directory.c:509 #3 0x00014001c7e3 in WCMD_list_directory .../wine/programs/cmd/directory.c:509 ... #23 0x00014001c7e3 in WCMD_list_directory .../wine/programs/cmd/directory.c:509 #24 0x00014001c7e3 in WCMD_list_directory .../wine/programs/cmd/directory.c:509 #25 0x00014001a525 in WCMD_directory .../wine/programs/cmd/directory.c:1000 #26 0x000140023e97 in WCMD_run_builtin_command .../wine/programs/cmd/wcmdmain.c:2244 #27 0x00014002964d in execute_single_command .../wine/programs/cmd/wcmdmain.c:2393 #28 0x0001400288ef in node_execute .../wine/programs/cmd/wcmdmain.c:4597 #29 0x00014002aba6 in wmain .../wine/programs/cmd/wcmdmain.c:4948 #30 0x000140037fec in wmainCRTStartup .../wine/dlls/msvcrt/crt_wmain.c:60 #31 0x6fffffc67a54 in BaseThreadInitThunk (C:\windows\system32\kernel32.dll+0x178027a54) #32 0x6fffffde06d6 in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x1700506d6) Address 0x7ffffe1ddea8 is located in stack of thread T0 at offset 2920 in frame #0 0x00014001b59f in WCMD_list_directory .../wine/programs/cmd/directory.c:242 This frame has 8 object(s): [32, 2080) 'string' (line 244) [2208, 2272) 'datestring' (line 244) [2304, 2368) 'timestring' (line 244) [2400, 2920) 'real_path' (line 245) <== Memory access at offset 2920 overflows this variable [3056, 3064) 'ft' (line 247) [3088, 3104) 'st' (line 248) [3120, 3168) 'username' (line 338) [3200, 3792) 'finddata' (line 465) HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp, SEH and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-overflow .../wine/include/winbase.h:2615 in lstrcatW ... ==520==ABORTING $ gdb-multiarch -q --pid $(pidof 'C:\windows\system32\cmd.exe') (gdb) b ReportError (gdb) b ReportGenericError (gdb) handle SIGSEGV nostop noprint (gdb) handle SIGUSR1 nostop noprint (gdb) cont (gdb) set osabi Windows (gdb) bt #0 ReportGenericError () at /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/asan_report.cpp:516 #1 0x00006ffffe8d7857 in __asan_report_store2 () at /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/asan_rtl.cpp:134 #2 0x000000014001a9e9 in lstrcatW (dst=<optimized out>, src=<optimized out>) at .../wine/include/winbase.h:2615 #3 0x000000014001b8ca in WCMD_list_directory (inputparms=0x7ef45afe0e50, level=<optimized out>, outputparms=<optimized out>) at .../wine/programs/cmd/directory.c:276 #4 0x000000014001c7e4 in WCMD_list_directory (inputparms=0x7ef45afe0e20, level=<optimized out>, outputparms=<optimized out>) at .../wine/programs/cmd/directory.c:509 #5 0x000000014001c7e4 in WCMD_list_directory (inputparms=0x7ef45afe0df0, level=<optimized out>, outputparms=<optimized out>) at .../wine/programs/cmd/directory.c:509 ... #25 0x000000014001c7e4 in WCMD_list_directory (inputparms=0x7ef45afe02e0, level=<optimized out>, outputparms=<optimized out>) at .../wine/programs/cmd/directory.c:509 #26 0x000000014001c7e4 in WCMD_list_directory (inputparms=0x7ef45afe0220, level=<optimized out>, outputparms=<optimized out>) at .../wine/programs/cmd/directory.c:509 #27 0x000000014001a526 in WCMD_directory (args=<optimized out>) at .../wine/programs/cmd/directory.c:1000 #28 0x0000000140023e98 in WCMD_run_builtin_command (cmd_index=8, cmd=0x7f405b008200 L"dir c:\\tmp.txt /s") at .../wine/programs/cmd/wcmdmain.c:2244 #29 0x000000014002964e in execute_single_command (command=<optimized out>) at .../wine/programs/cmd/wcmdmain.c:2393 #30 0x00000001400288f0 in node_execute (node=<optimized out>) at .../wine/programs/cmd/wcmdmain.c:4597 #31 0x000000014002aba7 in wmain (argc=<optimized out>, argvW=<optimized out>) at .../wine/programs/cmd/wcmdmain.c:4948 #32 0x0000000140037fed in wmainCRTStartup () at .../wine/dlls/msvcrt/crt_wmain.c:60 #33 0x00006fffffc67a55 in BaseThreadInitThunk () from .../wine-build/llvm-old64-asan-pe/obj/dlls/kernel32/x86_64-windows/kernel32.dll #34 0x00006fffffde06d7 in RtlUserThreadStart () from .../wine-build/llvm-old64-asan-pe/obj/dlls/ntdll/x86_64-windows/ntdll.dll #35 0x0000000000000000 in ?? () (gdb) up (gdb) up (gdb) up #3 0x000000014001b8ca in WCMD_list_directory (inputparms=0x7ef45afe0e50, level=<optimized out>, outputparms=<optimized out>) at .../wine/programs/cmd/directory.c:276 276 lstrcatW(real_path, parms->fileName); (gdb) set print elements 0 (gdb) print parms->dirName $1 = (WCHAR *) 0x7f1a5afe9080 L"c:\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\" (gdb) print parms->fileName $2 = (WCHAR *) 0x7ef25afe0bf0 L"tmp.txt" (gdb) print sizeof(real_path)/sizeof(*real_path) $3 = 260 ``` </details> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9577

2 2

[PATCH 0/1] MR9581: services: Return success for ChangeServiceConfig(SERVICE_CONFIG_SERVICE_SID_INFO).
by Dmitry Timoshkov (＠dmitry) Nov. 25, 2025

Nov. 25, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9581

2 1

[PATCH 0/2] MR9580: msado15: Fix crash in _Recordset::Close() when releasing uninitialized Field objects.
by Piotr Caban (＠piotr) Nov. 25, 2025

Nov. 25, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9580

2 2

[PATCH v4 0/3] MR8925: winemac.drv: Add EDID support.
by Jactry Zeng (＠jactry) Nov. 25, 2025

Nov. 25, 2025

-- v4: winemac.drv: Support to generate EDID from display parameters from Core Graphics APIs. winemac.drv: Support to get EDID from IODisplayConnect. winemac.drv: Support to get EDID from DCPAVServiceProxy. https://gitlab.winehq.org/wine/wine/-/merge_requests/8925

3 6

Re: [PATCH v2 0/1] MR9578: win32u: Ignore statup cmd show mode for owned windows.
by Paul Gofman (＠gofman) Nov. 25, 2025

Nov. 25, 2025

The extra 'first_window' check is to avoid additional calls to get_window_relative() which may result in server call (while we shouldn't InterlockedExchange(&first_window) for owned window). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9578#note_123590

1 0

[PATCH v5 0/3] MR9567: Draft: winegstreamer: Refactor WMSyncReader to use DMOs internally.
by Yuxuan Shui (＠yshui) Nov. 24, 2025

Nov. 24, 2025

-- v5: winegstreamer: Refactor WMSyncReader to use DMOs internally. https://gitlab.winehq.org/wine/wine/-/merge_requests/9567

2 3

Re: [PATCH v2 0/7] MR9554: Cmd engine rewrite (part XXXXI) - approved
by Alexandre Julliard (＠julliard) Nov. 24, 2025

Nov. 24, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9554

1 0

Re: [PATCH v2 0/1] MR9566: mfsrcsnk: Ignore streams with unsupported media types. - approved
by Alexandre Julliard (＠julliard) Nov. 24, 2025

Nov. 24, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9566

1 0