- Wine-GitLab - list.winehq.org

Re: [PATCH v3 0/5] MR10436: cfgmgr32: Implement CM_Get_DevNode_Registry_Property(_Ex)(A|W).
by Rémi Bernon March 24, 2026

March 24, 2026

v2: Tweak some tests for Gitlab CI Windows VMs. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10436#note_133532

1 0

Re: [PATCH v2 0/1] MR10352: cabinet: Add stubs for compressor/decompressor
by Nikolay Sivov (＠nsivov) March 24, 2026

March 24, 2026

On Tue Mar 24 09:29:24 2026 +0000, Chris Kadar wrote: > I believe this is the minimal stub for this game to work. > The call pattern I observed is that it will call Compress first with a 0 > byte input buffer, expecting to get ERROR_INSUFFICIENT_BUFFER back and > reads the output data size to produce a new buffer. It then re-calls the > function with the corrected size and expected data written to it. Could you check which algorithm this game is using? We have at least some MSZIP code scattered around, and maybe this could be consolidated at some point (not in this MR obviously). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10352#note_133527

1 0

Re: [PATCH v2 0/5] MR10429: msxml3/tests: Add some more DOM tests.
by Nikolay Sivov (＠nsivov) March 24, 2026

March 24, 2026

On Tue Mar 24 11:28:25 2026 +0000, Bernhard Übelacker wrote: > Hello @nsivov, the first patch e4832050f of this merge request triggers > ASan in `test_removeAttributeNode` in this CI runs: > [32bit](https://gitlab.winehq.org/bernhardu/wine/-/jobs/241883#L2771) [64bit](https://gitlab.winehq.org/bernhardu/wine/-/jobs/241884#L2990). > For completeness, this CI runs include also the additional patch from > !9279 by @yshui. > <details> > <summary>ASan details</summary> > ``` > ==msxml3_test.exe==428==ERROR: AddressSanitizer: heap-use-after-free on > address 0x025cc574 at pc 0x779a2d4a bp 0x0022fb14 sp 0x0022fb10 > READ of size 4 at 0x025cc574 thread T0 > #0 0x779a2d49 in domattr_get_namespaceURI /builds/bernhardu/wine/build64/../dlls/msxml3/attribute.c:546:36 > #1 0x004630d1 in IXMLDOMAttribute_get_namespaceURI /builds/bernhardu/wine/build64/include/msxml.h:3574:12 > #2 0x0044339b in test_removeAttributeNode /builds/bernhardu/wine/build64/../dlls/msxml3/tests/domdoc.c:14550:10 > #3 0x004011e8 in func_domdoc /builds/bernhardu/wine/build64/../dlls/msxml3/tests/domdoc.c:16092:5 > #4 0x004ad6f1 in run_test /builds/bernhardu/wine/build64/../include/wine/test.h:780:5 > #5 0x004ad1aa in main /builds/bernhardu/wine/build64/../include/wine/test.h:900:12 > ... > 0x025cc574 is located 36 bytes inside of 48-byte region [0x025cc550,0x025cc580) > freed by thread T0 here: > #0 0x785f558b in free /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/asan_malloc_win.cpp:78:3 > #1 0x77b1f262 in xmlFreeProp /builds/bernhardu/wine/build64/../libs/xml2/tree.c:2079:5 > #2 0x77b1f498 in xmlRemoveProp /builds/bernhardu/wine/build64/../libs/xml2/tree.c > #3 0x779d4eb9 in domelem_remove_qualified_item /builds/bernhardu/wine/build64/../dlls/msxml3/element.c:1754:13 > #4 0x779d4496 in domelem_remove_named_item /builds/bernhardu/wine/build64/../dlls/msxml3/element.c:1794:10 > #5 0x77a0dae8 in xmlnodemap_removeNamedItem /builds/bernhardu/wine/build64/../dlls/msxml3/nodemap.c:219:12 > #6 0x779d73d1 in IXMLDOMNamedNodeMap_removeNamedItem /builds/bernhardu/wine/build64/include/msxml6.h:5425:12 > #7 0x779d0fe1 in domelem_removeAttribute /builds/bernhardu/wine/build64/../dlls/msxml3/element.c:1341:10 > #8 0x00463071 in IXMLDOMElement_removeAttribute /builds/bernhardu/wine/build64/include/msxml.h:4104:12 > #9 0x0044329a in test_removeAttributeNode /builds/bernhardu/wine/build64/../dlls/msxml3/tests/domdoc.c:14541:10 > #10 0x004011e8 in func_domdoc /builds/bernhardu/wine/build64/../dlls/msxml3/tests/domdoc.c:16092:5 > #11 0x004ad6f1 in run_test /builds/bernhardu/wine/build64/../include/wine/test.h:780:5 > #12 0x004ad1aa in main /builds/bernhardu/wine/build64/../include/wine/test.h:900:12 > ... > previously allocated by thread T0 here: > #0 0x785f568b in malloc /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/asan_malloc_win.cpp:87:3 > #1 0x77b1e5c8 in xmlNewPropInternal /builds/bernhardu/wine/build64/../libs/xml2/tree.c:1851:24 > #2 0x77b1ed3c in xmlNewNsPropEatName /builds/bernhardu/wine/build64/../libs/xml2/tree.c:1979:12 > #3 0x77b84b25 in xmlSAX2AttributeInternal /builds/bernhardu/wine/build64/../libs/xml2/SAX2.c:1249:11 > #4 0x77b82dda in xmlSAX2StartElement /builds/bernhardu/wine/build64/../libs/xml2/SAX2.c:1662:7 > #5 0x77ac1554 in xmlParseStartTag /builds/bernhardu/wine/build64/../libs/xml2/parser.c > #6 0x77ac456b in xmlParseElementStart /builds/bernhardu/wine/build64/../libs/xml2/parser.c:10476:9 > #7 0x77ac4071 in xmlParseElement /builds/bernhardu/wine/build64/../libs/xml2/parser.c:10406:9 > #8 0x77ac81b7 in xmlParseDocument /builds/bernhardu/wine/build64/../libs/xml2/parser.c:11190:2 > #9 0x779c9243 in doparse /builds/bernhardu/wine/build64/../dlls/msxml3/domdoc.c:544:5 > #10 0x779c2d5a in domdoc_loadXML /builds/bernhardu/wine/build64/../dlls/msxml3/domdoc.c:2492:22 > #11 0x00452c64 in IXMLDOMDocument_loadXML /builds/bernhardu/wine/build64/include/msxml.h:1776:12 > #12 0x00442ecf in test_removeAttributeNode /builds/bernhardu/wine/build64/../dlls/msxml3/tests/domdoc.c:14503:10 > #13 0x004011e8 in func_domdoc /builds/bernhardu/wine/build64/../dlls/msxml3/tests/domdoc.c:16092:5 > #14 0x004ad6f1 in run_test /builds/bernhardu/wine/build64/../include/wine/test.h:780:5 > #15 0x004ad1aa in main /builds/bernhardu/wine/build64/../include/wine/test.h:900:12 > ... > SUMMARY: AddressSanitizer: heap-use-after-free > /builds/bernhardu/wine/build64/../dlls/msxml3/attribute.c:546:36 in domattr_get_namespaceURI > ``` > </details> Thank you, I'll skip it on Wine for now, in !10435. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10429#note_133525

1 0

[PATCH v2 0/9] MR10435: msxml3/tests: Add ISupportErrorInfo tests for DOCTYPE nodes.
by Nikolay Sivov (＠nsivov) March 24, 2026

March 24, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: msxml3/tests: Skip removeAttributeNode() tests on Wine. msxml3/tests: Remove some value testing macros. msxml3/tests: Add some more appendChild() tests. msxml3/tests: Add another get_xml() test for namespace definitions. msxml3/tests: Use string comparison in more places. msxml3/tests: Add some cloneNode() tests for a document. msxml3/tests: Add parentNode() test for attributes. msxml3/tests: Add basic argument test for loadXML(). msxml3/tests: Add ISupportErrorInfo tests for DOCTYPE nodes. https://gitlab.winehq.org/wine/wine/-/merge_requests/10435

2 9

[PATCH 0/5] MR10436: cfgmgr32: Implement CM_Get_DevNode_Registry_Property(_Ex)(A|W).
by Rémi Bernon March 24, 2026

March 24, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10436

1 5

Re: [PATCH v2 0/5] MR10429: msxml3/tests: Add some more DOM tests.
by Bernhard Übelacker March 24, 2026

March 24, 2026

Hello @nsivov, the first patch e4832050f of this merge request triggers ASan in `test_removeAttributeNode` in this CI runs: [32bit](https://gitlab.winehq.org/bernhardu/wine/-/jobs/241883#L2771) [64bit](https://gitlab.winehq.org/bernhardu/wine/-/jobs/241884#L2990). For completeness, this CI runs include also the additional patch from !9279 by @yshui. <details> <summary>ASan details</summary> ``` ==msxml3_test.exe==428==ERROR: AddressSanitizer: heap-use-after-free on address 0x025cc574 at pc 0x779a2d4a bp 0x0022fb14 sp 0x0022fb10 READ of size 4 at 0x025cc574 thread T0 #0 0x779a2d49 in domattr_get_namespaceURI /builds/bernhardu/wine/build64/../dlls/msxml3/attribute.c:546:36 #1 0x004630d1 in IXMLDOMAttribute_get_namespaceURI /builds/bernhardu/wine/build64/include/msxml.h:3574:12 #2 0x0044339b in test_removeAttributeNode /builds/bernhardu/wine/build64/../dlls/msxml3/tests/domdoc.c:14550:10 #3 0x004011e8 in func_domdoc /builds/bernhardu/wine/build64/../dlls/msxml3/tests/domdoc.c:16092:5 #4 0x004ad6f1 in run_test /builds/bernhardu/wine/build64/../include/wine/test.h:780:5 #5 0x004ad1aa in main /builds/bernhardu/wine/build64/../include/wine/test.h:900:12 ... 0x025cc574 is located 36 bytes inside of 48-byte region [0x025cc550,0x025cc580) freed by thread T0 here: #0 0x785f558b in free /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/asan_malloc_win.cpp:78:3 #1 0x77b1f262 in xmlFreeProp /builds/bernhardu/wine/build64/../libs/xml2/tree.c:2079:5 #2 0x77b1f498 in xmlRemoveProp /builds/bernhardu/wine/build64/../libs/xml2/tree.c #3 0x779d4eb9 in domelem_remove_qualified_item /builds/bernhardu/wine/build64/../dlls/msxml3/element.c:1754:13 #4 0x779d4496 in domelem_remove_named_item /builds/bernhardu/wine/build64/../dlls/msxml3/element.c:1794:10 #5 0x77a0dae8 in xmlnodemap_removeNamedItem /builds/bernhardu/wine/build64/../dlls/msxml3/nodemap.c:219:12 #6 0x779d73d1 in IXMLDOMNamedNodeMap_removeNamedItem /builds/bernhardu/wine/build64/include/msxml6.h:5425:12 #7 0x779d0fe1 in domelem_removeAttribute /builds/bernhardu/wine/build64/../dlls/msxml3/element.c:1341:10 #8 0x00463071 in IXMLDOMElement_removeAttribute /builds/bernhardu/wine/build64/include/msxml.h:4104:12 #9 0x0044329a in test_removeAttributeNode /builds/bernhardu/wine/build64/../dlls/msxml3/tests/domdoc.c:14541:10 #10 0x004011e8 in func_domdoc /builds/bernhardu/wine/build64/../dlls/msxml3/tests/domdoc.c:16092:5 #11 0x004ad6f1 in run_test /builds/bernhardu/wine/build64/../include/wine/test.h:780:5 #12 0x004ad1aa in main /builds/bernhardu/wine/build64/../include/wine/test.h:900:12 ... previously allocated by thread T0 here: #0 0x785f568b in malloc /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/asan_malloc_win.cpp:87:3 #1 0x77b1e5c8 in xmlNewPropInternal /builds/bernhardu/wine/build64/../libs/xml2/tree.c:1851:24 #2 0x77b1ed3c in xmlNewNsPropEatName /builds/bernhardu/wine/build64/../libs/xml2/tree.c:1979:12 #3 0x77b84b25 in xmlSAX2AttributeInternal /builds/bernhardu/wine/build64/../libs/xml2/SAX2.c:1249:11 #4 0x77b82dda in xmlSAX2StartElement /builds/bernhardu/wine/build64/../libs/xml2/SAX2.c:1662:7 #5 0x77ac1554 in xmlParseStartTag /builds/bernhardu/wine/build64/../libs/xml2/parser.c #6 0x77ac456b in xmlParseElementStart /builds/bernhardu/wine/build64/../libs/xml2/parser.c:10476:9 #7 0x77ac4071 in xmlParseElement /builds/bernhardu/wine/build64/../libs/xml2/parser.c:10406:9 #8 0x77ac81b7 in xmlParseDocument /builds/bernhardu/wine/build64/../libs/xml2/parser.c:11190:2 #9 0x779c9243 in doparse /builds/bernhardu/wine/build64/../dlls/msxml3/domdoc.c:544:5 #10 0x779c2d5a in domdoc_loadXML /builds/bernhardu/wine/build64/../dlls/msxml3/domdoc.c:2492:22 #11 0x00452c64 in IXMLDOMDocument_loadXML /builds/bernhardu/wine/build64/include/msxml.h:1776:12 #12 0x00442ecf in test_removeAttributeNode /builds/bernhardu/wine/build64/../dlls/msxml3/tests/domdoc.c:14503:10 #13 0x004011e8 in func_domdoc /builds/bernhardu/wine/build64/../dlls/msxml3/tests/domdoc.c:16092:5 #14 0x004ad6f1 in run_test /builds/bernhardu/wine/build64/../include/wine/test.h:780:5 #15 0x004ad1aa in main /builds/bernhardu/wine/build64/../include/wine/test.h:900:12 ... SUMMARY: AddressSanitizer: heap-use-after-free /builds/bernhardu/wine/build64/../dlls/msxml3/attribute.c:546:36 in domattr_get_namespaceURI ``` </details> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10429#note_133521

1 0

[PATCH v3 0/2] MR10271: Fixed thread safety issues with NtUserRegistClassExWOW and NtUserUnregisterClass.
by Yongjie Yao (＠yaoyongjie) March 24, 2026

March 24, 2026

Kingsoft Typing Pass failed to start probabilistically due to a deadlock between two threads registering and unregistering the same class. The replication scenario is as follows: |A thread (registration class) | B thread (deregistration class)| |-------------- |---------------| | NtUserRegisterClassExWOW | NtUserUnregisterClass | | create_class | -- | | -- | destroy_class | | find_shared_session_object | -- | | find failed, destroy_class | -- | | free class | -- | | -- | user_lock | | -- | remove class from list | | -- | throw exception(class has freeed by thread A) | Thread B threw an exception and will not call user_unlock. The upper layer application handled the memory access exception thrown by thread B, but due to If user_unlock is not called, the lock will remain occupied, and other threads will continue to wait when calling user_rock. -- v3: Win32u: Fixed thread safety issues with NtUserRegistClassExWOW and NtUserUnregisterClass. user32/tests: Test the thread safety of NtUserRegisterClassExWOW and NtUserUnregisterClass. https://gitlab.winehq.org/wine/wine/-/merge_requests/10271

3 3

Re: [PATCH v2 0/1] MR10352: cabinet: Add stubs for compressor/decompressor
by Nikolay Sivov (＠nsivov) March 24, 2026

March 24, 2026

On Tue Mar 24 09:56:11 2026 +0000, Hans Leidekker wrote: > Should the last parameter to FCICompressorCreate() be HFCICOMPRESSOR * ? Yes, but it's called PCOMPRESSOR_HANDLE. Types should be revised too of course, not only names. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10352#note_133519

1 0

Re: [PATCH v2 0/1] MR10352: cabinet: Add stubs for compressor/decompressor
by Hans Leidekker (＠hans) March 24, 2026

March 24, 2026

On Tue Mar 24 09:29:41 2026 +0000, Nikolay Sivov wrote: > Yes, existing exports should of course stay as is. Newer exports are > different, and we can't change that. Should the last parameter to FCICompressorCreate() be HFCICOMPRESSOR * ? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10352#note_133518

1 0

[PATCH 0/8] MR10435: msxml3/tests: Add ISupportErrorInfo tests for DOCTYPE nodes.
by Nikolay Sivov (＠nsivov) March 24, 2026

March 24, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10435

2 8