- Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/2] MR9266: msxml6/tests: Move remaining tests for SAXXMLReader60. - approved
by Alexandre Julliard (＠julliard) Oct. 24, 2025

Oct. 24, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9266

1 0

Re: [PATCH v5 0/5] MR7570: mfreadwrite: Implement encoder creation. (Part 1) - approved
by Alexandre Julliard (＠julliard) Oct. 24, 2025

Oct. 24, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7570

1 0

Re: [PATCH v4 0/8] MR9252: mshtml: Implement checkValidity for input elements.
by Gabriel Ivăncescu Oct. 24, 2025

Oct. 24, 2025

On Fri Oct 24 16:46:37 2025 +0000, Chunhao Hung wrote: > OK i found, if wine has both dlls/mshtml/mshtml_private_iface.h and > build/dlls/mshtml/mshtml_private_iface.h. the build sequence will first > use the dlls/mshtml/mshtml_private_iface.h and failed ... `mshtml_private_iface.idl` is an idl file, not a .h file. The .h file is generated from it and is in the build directory. That's why I asked for a clean build, since it was likely still there generated from before the MR and didn't get re-generated for some reason. If you did try a clean build and it still generated it wrongly, I really have no idea what is going on, but I'm assuming you made a mistake somewhere. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9252#note_119586

1 0

[PATCH 0/1] MR9277: winex11: Don't keep track of the minimized window rects.
by Rémi Bernon Oct. 24, 2025

Oct. 24, 2025

We use the window vs visible rect differences to compute the new window rect from its visible rect changes in window_update_client_config. When a window gets restored the win32 minimized rect differences won't match the restored rect differences and the computation is wrong if we do it on the minimized rects, as it need to happen before the actual SC_RESTORE command it sent. The minimized rects shouldn't matter as we use minimized style directly, and they also cause trouble with empty client areas, so better ignore them. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58852 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9277

1 1

[PATCH 0/2] MR9276: ntdll: Implement and use NtAlertMultipleThreadByThreadId().
by Paul Gofman (＠gofman) Oct. 24, 2025

Oct. 24, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9276

2 3

Re: [PATCH v4 0/8] MR9252: mshtml: Implement checkValidity for input elements.
by Chunhao Hung (＠otakuxtom) Oct. 24, 2025

Oct. 24, 2025

On Fri Oct 24 16:40:20 2025 +0000, Chunhao Hung wrote: > yep I even delete the build directory, check to master and still failed. > Now I found there are actually missing IWineHTMLFormPrivate in mshtml_private_iface.h OK i found, if wine has both dlls/mshtml/mshtml_private_iface.h and build/dlls/mshtml/mshtml_private_iface.h. the build sequence will first use the dlls/mshtml/mshtml_private_iface.h and failed ... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9252#note_119574

1 0

Re: [PATCH v4 0/8] MR9252: mshtml: Implement checkValidity for input elements.
by Chunhao Hung (＠otakuxtom) Oct. 24, 2025

Oct. 24, 2025

On Fri Oct 24 16:35:40 2025 +0000, Gabriel Ivăncescu wrote: > That's weird. Did you try a clean build from scratch? yep I even delete the build directory, check to master and still failed. Now I found there are actually missing IWineHTMLFormPrivate in mshtml_private_iface.h -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9252#note_119573

1 0

Re: [PATCH v4 0/8] MR9252: mshtml: Implement checkValidity for input elements.
by Gabriel Ivăncescu Oct. 24, 2025

Oct. 24, 2025

On Fri Oct 24 16:35:40 2025 +0000, Chunhao Hung wrote: > I build failed on mshtml due to this MR. ‘IID_IWineHTMLInputPrivate’ > undeclared here (not in a function); did you mean ‘IID_IWineHTMLWindowPrivate’? > before this MR build is success. after revert is also build success. That's weird. Did you try a clean build from scratch? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9252#note_119572

1 0

[PATCH 0/1] MR9261: uxtheme: Hide a few unused ordinals.
by Louis Lenders (＠xe) Oct. 24, 2025

Oct. 24, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58747 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9261

3 8

[PATCH 0/1] MR9274: uxtheme: Add a stub at ordinal 49.
by Zhiyi Zhang (＠zhiyi) Oct. 24, 2025

Oct. 24, 2025

DrawThemeBackground() happens to be at ordinal 49 before this patch. Add a stub for ordinal 49 so that DrawThemeBackground() is not called. Otherwise, it might cause a crash. The stub is enough for Directory Opus to start. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58747 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9274

2 1