- Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/1] MR8793: server: Check thread and call parameters in (queue_apc) for APC_USER. - approved
by Alexandre Julliard (＠julliard) Aug. 20, 2025

Aug. 20, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8793

1 0

Re: [PATCH v3 0/2] MR8786: Draft: winebuild: Add flag to disable dynamicbase/aslr
by Tres Finocchiaro (＠tresf) Aug. 20, 2025

Aug. 20, 2025

On Wed Aug 20 19:57:20 2025 +0000, Alexandre Julliard wrote: > DYNAMICBASE by itself is not meaningful for .exe.so binaries, they are > mapped by the Unix loader anyway, which provides its own ASLR. >From my understanding, `winebuild` influences the PE section of this binary, which IS meaningful. This is reinforced by the fact that our plugins stop crashing when it's disabled. The `HIGHENTROPYVA` should have no effect if `DYNAMICBASE` is off, so I can see a "not meaningful" there (but only on mutual exclusion), but I wanted to keep the PR as simple as possible. I understand that Unix has [its own ASLR that's on by default](https://askubuntu.com/questions/318315), but to deny the meaningfulness of this flag seems -- respectively -- incorrect. This regression was introduced with 518e394794160818ffe6826c874ff2f550c95bbb and can be reverted just the same. I'm only asking to give `winegcc` (or more specifically `winebuild`) devs the ability to control it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8786#note_113323

1 0

[PATCH v2 0/6] MR8797: Implement GetProcessPriorityBoost/SetProcessPriorityBoost
by Marc-Aurel Zent (＠mzent) Aug. 20, 2025

Aug. 20, 2025

-- v2: kernel32/tests: Add tests for GetProcessPriorityBoost/SetProcessPriorityBoost. kernelbase: Implement SetProcessPriorityBoost. kernelbase: Implement GetProcessPriorityBoost. ntdll: Implement ProcessPriorityBoost class in NtSetInformationProcess. server: Add set_thread_disable_boost() helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/8797

3 9

Re: [PATCH v3 0/2] MR8786: Draft: winebuild: Add flag to disable dynamicbase/aslr
by Alexandre Julliard (＠julliard) Aug. 20, 2025

Aug. 20, 2025

On Wed Aug 20 19:41:56 2025 +0000, Tres Finocchiaro wrote: > `HIGHENTROPYVA:NO` allows `DYNAMICBASE` to remain active for both 32-bit > and 64-bit executables while only disabling the 64-bit `HIGHENTROPYVA` > features. Since `DYNAMICBASE` is widely preferred for security > purposes, this provides just-enough granularity to close > [#58480](https://bugs.winehq.org/show_bug.cgi?id=58480), and matches > more closely to that of cygwin and MSVC compilers. Note that this > `HIGHENTROPYVA:NO` solution is new information since creating that bug report. > On the other hand, if it's winehq's stance that these flags should be > toggled together, I'd happily change this back. I was fearful that > handling them together may not be succinct enough, but I'm happy to oblige. DYNAMICBASE by itself is not meaningful for .exe.so binaries, they are mapped by the Unix loader anyway, which provides its own ASLR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8786#note_113321

1 0

Re: [PATCH v3 0/2] MR8786: Draft: winebuild: Add flag to disable dynamicbase/aslr
by Tres Finocchiaro (＠tresf) Aug. 20, 2025

Aug. 20, 2025

On Wed Aug 20 18:17:23 2025 +0000, Alexandre Julliard wrote: > That second flag doesn't seem necessary. `HIGHENTROPYVA:NO` allows `DYNAMICBASE` to remain active for both 32-bit and 64-bit executables while only disabling the 64-bit `HIGHENTROPYVA` features. Since `DYNAMICBASE` is widely preferred for security purposes, this provides just-enough granularity to close [#58480](https://bugs.winehq.org/show_bug.cgi?id=58480), and matches more closely to that of cygwin and MSVC compilers. Note that this `HIGHENTROPYVA:NO` solution is new information since creating that bug report. On the other hand, if it's winehq's stance that these flags should be toggled together, I'd happily change this back. I was fearful that handling them together may not be succinct enough, but I'm happy to oblige. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8786#note_113319

1 0

[PATCH v2 0/3] MR8774: vccorlib140: Add an initial implementation for allocation primitives.
by Vibhav Pant (＠vibhavp) Aug. 20, 2025

Aug. 20, 2025

The `Allocate` method has two variants: * Allocate(size_t): Performs a normal allocation, but throws a COMException on OOM. * Allocate(ptrdiff_t offset, size_t size): Allocates a block of size `size`, and initializes a control block for an `IWeakReference` at `offset`. The weak reference resolves to the allocated object, which can finally be freed by calling `ControlBlock::ReleaseTarget`. The IWeakReference implementation seems to be rather odd, which I have tried to demonstrate (and test) in the unit tests: * `ReleaseTarget` only frees the object if the strong ref count is _below_ 0. * `IWeakReference::Resolve` will _not_ set the output pointer to `NULL` if the weak reference is no longer alive. This MR implements these functions sans exception support. -- v2: vccorlib140: Implement Platform::Details::{Allocate(ptrdiff_t, size_t), ControlBlock::ReleaseTarget}. vccorlib140: Add stub for Platform::Details::{Allocate(ptrdiff_t, size_t), ControlBlock::ReleaseTarget}. https://gitlab.winehq.org/wine/wine/-/merge_requests/8774

4 5

[PATCH v2 0/1] MR8758: winegstreamer: Use a stride alignment of 2 for NV12 in align_video_info_planes().
by Conor McCarthy (＠cmccarthy) Aug. 20, 2025

Aug. 20, 2025

Fixes the todos in !8034. -- v2: winegstreamer: Use a stride alignment of 2 for NV12 in align_video_info_planes(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8758

3 3

[PATCH v3 0/3] MR8792: msvcp140_atomic_wait: A few std::chrono::tzdb semi-stubs.
by Paul Gofman (＠gofman) Aug. 20, 2025

Aug. 20, 2025

-- v3: msvcp140_atomic_wait: Stub __std_tzdb_get_leap_seconds() / __std_tzdb_delete_leap_seconds(). msvcp140_atomic_wait: Semi-stub __std_tzdb_get_current_zone() / __std_tzdb_delete_current_zone(). msvcp140_atomic_wait: Semi-stub __std_tzdb_get_time_zones() / __std_tzdb_delete_time_zones(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8792

3 5

[PATCH v2 0/3] MR8792: msvcp140_atomic_wait: A few std::chrono::tzdb semi-stubs.
by Paul Gofman (＠gofman) Aug. 20, 2025

Aug. 20, 2025

-- v2: msvcp140_atomic_wait: Stub __std_tzdb_get_leap_seconds() / __std_tzdb_delete_leap_seconds(). msvcp140_atomic_wait: Semi-stub __std_tzdb_get_current_zone() / __std_tzdb_delete_current_zone(). msvcp140_atomic_wait: Semi-stub __std_tzdb_get_time_zones() / __std_tzdb_delete_time_zones(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8792

3 6

Re: [PATCH v3 0/2] MR8786: Draft: winebuild: Add flag to disable dynamicbase/aslr
by Alexandre Julliard (＠julliard) Aug. 20, 2025

Aug. 20, 2025

On Wed Aug 20 17:08:48 2025 +0000, Tres Finocchiaro wrote: > I've added a second flag for `HIGHENTROPYVA`. This new flag is longer > and breaks some styling. Any advice is greatly appreciated. I've > placed the style foopahs inline. That second flag doesn't seem necessary. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8786#note_113306

1 0