- Wine-GitLab - list.winehq.org

Re: [PATCH v17 0/4] MR8478: cfgmgr32: Device query API part 2: Implement object properties and initial device enumeration in DevCreateObjectQuery
by Yuxuan Shui (＠yshui) July 21, 2025

July 21, 2025

Yuxuan Shui (@yshui) commented about dlls/cfgmgr32/main.c: > + struct device_query_context *ctx = data; > + HRESULT hr = S_OK; > + ULONG i; > > - for (i = 0; SUCCEEDED( hr ); i++) > + action_data.Action = DevQueryResultAdd; > + action_data.Data.DeviceObject = obj; > + ctx->callback( (HDEVQUERY)ctx, ctx->user_data, &action_data ); > + > + EnterCriticalSection( &ctx->cs ); > + if (ctx->state == DevQueryStateClosed) > + hr = E_CHANGED_STATE; > + LeaveCriticalSection( &ctx->cs ); > + > + for (i = 0; i < obj.cPropertyCount; i++) > + free( props->Buffer ); oops -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8478#note_110551

1 0

[PATCH 0/19] MR8599: mshtml: Only allow a specific set of builtin props as attributes.
by Gabriel Ivăncescu July 21, 2025

July 21, 2025

-- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/8599

2 2

Re: [PATCH v7 0/4] MR8595: comctl32: Separate v5 and v6.
by Elizabeth Figura (＠zfigura) July 21, 2025

July 21, 2025

On Mon Jul 21 18:34:10 2025 +0000, Nikolay Sivov wrote: > Windows SDK always defines it to either 5, or 6 for XP and newer. > Nothing in headers depends on it. So it's not the same as with d3dx. But it is the same as d3dx. Windows headers don't check D3DX_SDK_VERSION and conditionally define things the same way we do. They just ship multiple versions of the same file with different contents and different values of D3DX_SDK_VERSION. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8595#note_110541

1 0

[PATCH v2 0/4] MR8592: ntdll: Make wait in wait_async() always non-alertable.
by Paul Gofman (＠gofman) July 21, 2025

July 21, 2025

-- v2: server: Set IOSB for cancelled asyncs in async_terminate(). ntdll: Make wait in wait_async() always non-alertable. ntdll: Factor out test_alert_with_status(). ntdll/tests: Add more tests for canceling synchronous IO. https://gitlab.winehq.org/wine/wine/-/merge_requests/8592

3 7

Re: [PATCH v7 0/4] MR8595: comctl32: Separate v5 and v6.
by Nikolay Sivov (＠nsivov) July 21, 2025

July 21, 2025

On Mon Jul 21 18:05:49 2025 +0000, Elizabeth Figura wrote: > Wait, why, though? This is the approach we use for e.g. d3dx. Windows SDK always defines it to either 5, or 6 for XP and newer. Nothing in headers depends on it. So it's not the same as with d3dx. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8595#note_110536

1 0

Re: [PATCH v7 0/4] MR8595: comctl32: Separate v5 and v6.
by Elizabeth Figura (＠zfigura) July 21, 2025

July 21, 2025

On Mon Jul 21 06:09:39 2025 +0000, Zhiyi Zhang wrote: > changed this line in [version 6 of the diff](/wine/wine/-/merge_requests/8595/diffs?diff_id=194446&start_sha=4ae32c680b3c52bdfa972a955a18abeeb0532ec1#515e569bebc6ce6f3ec15b1e7bd470691646060a_4_4) Wait, why, though? This is the approach we use for e.g. d3dx. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8595#note_110534

1 0

[PATCH 0/1] MR8611: winebth.sys: Only set properties for radio devices after they have been started.
by Vibhav Pant (＠vibhavp) July 21, 2025

July 21, 2025

If bluetooth_radio_set_properties gets called before the PnP manager has enumerated the radio device, IoSetDevicePropertyData will fail as the registry entries for the radio's instance ID have not been created yet. This would result in the following error messages whenever a new prefix was created: ``` 011c:err:plugplay:IoSetDevicePropertyData Failed to open device, error 0xe000020b. 011c:err:plugplay:IoSetDevicePropertyData Failed to open device, error 0xe000020b. 011c:err:plugplay:IoSetDevicePropertyData Failed to open device, error 0xe000020b. 011c:err:plugplay:IoSetDevicePropertyData Failed to open device, error 0xe000020b. ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8611

2 1

[PATCH v2 0/6] MR8556: winebth.sys part 13: Add support for retrieving GATT characteristics
by Vibhav Pant (＠vibhavp) July 21, 2025

July 21, 2025

-- v2: bluetoothapis/tests: Implement tests for BluetoothGATTGetCharacteristics. bluetoothapis: Implement BluetoothGATTGetCharacteristics. winebth.sys: Remove GATT characteristic entries when they are removed from the Unix Bluetooth service. winebth.sys: Implement IOCTL_WINEBTH_LE_DEVICE_GET_GATT_CHARACTERISTICS. https://gitlab.winehq.org/wine/wine/-/merge_requests/8556

4 9

Re: [PATCH v2 0/1] MR8578: server: Allow for deletion of socket files.
by Loïc Rebmeister July 21, 2025

July 21, 2025

Loïc Rebmeister (@Fox2Code) commented about server/fd.c: > > if (fd->unix_fd == -1) > { > + if (stat( name, &st )) > + { > + file_set_error(); > + goto error; > + } I think the `stat` call should be moved after the "check for trailing slash on file path" code. As if the stat check is done here, the "check for trailing slash on file path" code path would no longer be called for `C:\NonExistingFolder\`. Everything else seems fine to me, I took my time reading to make sure I fully understood the code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8578#note_110527

1 0

[PATCH v2 0/3] MR8604: propsys: Implement PropVariantChangeType(VT_CLSID) for string types.
by Vibhav Pant (＠vibhavp) July 21, 2025

July 21, 2025

Also, add todo'd conformance tests for converting to and from `VT_ARRAY | VT_UI1` values. -- v2: propsys/tests: Add test for PropVariantToGUID with VT_ARRAY | VT_UI1 values. https://gitlab.winehq.org/wine/wine/-/merge_requests/8604

3 4