- Wine-GitLab - list.winehq.org

[PATCH v5 0/1] MR8466: ntdll: Also restore rbp before calling user mode callback.
by Yuxuan Shui (＠yshui) July 5, 2025

July 5, 2025

If wine dlls are built with frame pointers enabled, the frame pointer will be used during unwinding. If we don't restore frame pointer before calling the user mode callback, then later when the unwinder encounters the user mode callback frame, it will set the frame pointer to something unexpected (depends on what it was during `call_user_mode_callback`). Then for the subsequent frame it adjusts the stack pointer based on the frame pointer, thus derailing the unwinding process. -- v5: ntdll: Also restore rbp before calling user mode callback. https://gitlab.winehq.org/wine/wine/-/merge_requests/8466

3 12

Re: [PATCH v4 0/1] MR8467: conhost: Implement F1 and F3 support for history retrieval.
by eric pouech (＠epo) July 5, 2025

July 5, 2025

eric pouech (@epo) commented about programs/conhost/conhost.c: > +{ > + if (console->edit_line.history_index) > + { > + unsigned int index = console->edit_line.history_index - 1; > + struct edit_line *ctx = &console->edit_line; > + WCHAR *line = edit_line_history(console, index); > + unsigned int len = line ? lstrlenW(line) : 0; > + > + if (len > ctx->cursor) > + { > + unsigned int ccount = (copycount > 0) ? copycount : len - ctx->cursor; > + > + /* Clean the screen. */ > + edit_line_delete(console, ctx->cursor, ctx->len); > + /* Insert new string. */ > + if (edit_line_grow(console, len + 1)) this will overallocate -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8467#note_108892

1 0

Re: [PATCH v4 0/1] MR8467: conhost: Implement F1 and F3 support for history retrieval.
by eric pouech (＠epo) July 5, 2025

July 5, 2025

eric pouech (@epo) commented about programs/conhost/conhost.c: > while (ctx->history_index != start_pos); > } > > +static void edit_line_copy_from_hist( struct console *console, int copycount ) > +{ > + if (console->edit_line.history_index) > + { > + unsigned int index = console->edit_line.history_index - 1; > + struct edit_line *ctx = &console->edit_line; > + WCHAR *line = edit_line_history(console, index); > + unsigned int len = line ? lstrlenW(line) : 0; > + > + if (len > ctx->cursor) it looks like native is doing stuff a bit more complicated: * the MR implements the case where cursor is at the end of edit line * if cursor is not at the end, it looks native just advance cursor by ccount -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8467#note_108891

1 0

Re: [PATCH v4 0/1] MR8467: conhost: Implement F1 and F3 support for history retrieval.
by eric pouech (＠epo) July 5, 2025

July 5, 2025

eric pouech (@epo) commented about programs/conhost/conhost.c: > while (ctx->history_index != start_pos); > } > > +static void edit_line_copy_from_hist( struct console *console, int copycount ) > +{ > + if (console->edit_line.history_index) > + { > + unsigned int index = console->edit_line.history_index - 1; why -1? you could probably swap this line with next to use `ctx` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8467#note_108889

1 0

Re: [PATCH v4 0/1] MR8467: conhost: Implement F1 and F3 support for history retrieval.
by eric pouech (＠epo) July 5, 2025

July 5, 2025

eric pouech (@epo) commented about programs/conhost/conhost.c: > while (ctx->history_index != start_pos); > } > > +static void edit_line_copy_from_hist( struct console *console, int copycount ) > +{ > + if (console->edit_line.history_index) > + { > + unsigned int index = console->edit_line.history_index - 1; > + struct edit_line *ctx = &console->edit_line; > + WCHAR *line = edit_line_history(console, index); since you're not changing the `console->history` content, you could access `console->history[index]` directly (that would save recomputing the length, and one allocation) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8467#note_108890

1 0

Re: [PATCH v4 0/1] MR8467: conhost: Implement F1 and F3 support for history retrieval.
by eric pouech (＠epo) July 5, 2025

July 5, 2025

eric pouech (@epo) commented about programs/conhost/conhost.c: > while (ctx->history_index != start_pos); > } > > +static void edit_line_copy_from_hist( struct console *console, int copycount ) for consistency with other entries, please use `_history` instead of `_hist` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8467#note_108888

1 0

[PATCH v3 0/4] MR8500: Some improvements to widl.
by eric pouech (＠epo) July 5, 2025

July 5, 2025

This MR improves widl with : - fixes a segfault when inheriting from an incomplete interface (prints an error message instead), - supports (for C++) inheriting from interfaces which are declared after the declaration of the derived interface. -- v3: include: Remove duplicated declarations in .idl files. tools/widl: Ensure inherited interface is declared before using it. tools/widl: Remove unneeded condition. tools/widl: Fix segfault when inheriting from an incomplete interface. https://gitlab.winehq.org/wine/wine/-/merge_requests/8500

3 6

[PATCH 0/1] MR8509: hid: Implement HidP_SetData.
by Oleg Makarenko (＠JacKeTUs) July 5, 2025

July 5, 2025

This allows Simhub to detect various devices. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58441 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8509

3 2

[PATCH v4 0/1] MR8466: ntdll: Also restore rbp before calling user mode callback.
by Yuxuan Shui (＠yshui) July 5, 2025

July 5, 2025

If wine dlls are built with frame pointers enabled, the frame pointer will be used during unwinding. If we don't restore frame pointer before calling the user mode callback, then later when the unwinder encounters the user mode callback frame, it will set the frame pointer to something unexpected (depends on what it was during `call_user_mode_callback`). Then for the subsequent frame it adjusts the stack pointer based on the frame pointer, thus derailing the unwinding process. -- v4: ntdll: Also restore rbp before calling user mode callback. https://gitlab.winehq.org/wine/wine/-/merge_requests/8466

3 6

[PATCH v3 0/1] MR8466: ntdll: Also restore rbp before calling user mode callback.
by Yuxuan Shui (＠yshui) July 5, 2025

July 5, 2025

If wine dlls are built with frame pointers enabled, the frame pointer will be used during unwinding. If we don't restore frame pointer before calling the user mode callback, then later when the unwinder encounters the user mode callback frame, it will set the frame pointer to something unexpected (depends on what it was during `call_user_mode_callback`). Then for the subsequent frame it adjusts the stack pointer based on the frame pointer, thus derailing the unwinding process. -- v3: ntdll: Also restore rbp before calling user mode callback. https://gitlab.winehq.org/wine/wine/-/merge_requests/8466

4 19