- Wine-GitLab - list.winehq.org

[PATCH v2 0/1] MR8352: xcopy: Fix out-of-bound access when parsing arguments.
by Yuxuan Shui (＠yshui) June 18, 2025

June 18, 2025

We didn't check if the argument string is long enough before indexing into it. -- v2: xcopy: Fix out-of-bound access when parsing arguments. https://gitlab.winehq.org/wine/wine/-/merge_requests/8352

3 2

[PATCH 0/1] MR8352: xcopy: Fix out-of-bound access when parsing arguments.
by Yuxuan Shui (＠yshui) June 18, 2025

June 18, 2025

We didn't check if the argument string is long enough before indexing into it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8352

4 7

[PATCH 0/1] MR8361: shell32/tests: Fix expected ret for moving file to empty destination.
by Yuxuan Shui (＠yshui) June 18, 2025

June 18, 2025

Related to 57817044b983683f115edea6c5068ed6cddd858b. I believe originally the missing double null terminator caused Windows to take garbage memory as file name resulted in the ERROR_FILE_NOT_FOUND. Now it's fixed we are seeing what Windows actually returns. !8316 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8361

2 1

[PATCH v2 0/1] MR8350: crypt32: Handle missing attributes in CDecodeSignedMsg_GetParam.
by Yuxuan Shui (＠yshui) June 18, 2025

June 18, 2025

* * * While investigating another problem, I found we are handling empty attributes list differently compared native. But the actual problem is this, shouldn't `CRYPT_SizeOfAttributes` add `sizeof(CRYPT_ATTRIBUTES)` to `size`? Basically we return `size == 0` when the attributes list is empty, so the caller allocates zero bytes and call `GetParam` again, and we write out-of-bound trying to `out->cAttrs = in->cAttrs` in `CRYPT_ConstructAttributes`. (Of course with this MR this problem no longer show up, but the question still stands.) -- v2: crypt32: Handle missing attributes in CDecodeSignedMsg_GetParam. https://gitlab.winehq.org/wine/wine/-/merge_requests/8350

2 1

[PATCH v11 0/6] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Yongjie Yao (＠yaoyongjie) June 18, 2025

June 18, 2025

In CopyFileEx, and DeleteFile functions, by default, the file name and path are limited to MAX_PATH characters. To extend this limit to 32,767 wide characters, need prepend "\\\\?\\" to the path. -- v11: kernelbase: Limit the maximum path length for DeleteFile. kernelbase: Fix DeleteFileA doesn't support long path. kernelbase: Limit the maximum path length for filesystem. ntdll: Check if long path aware is enabled. kernel32/tests: Add tests for DeleteFile kernel32/tests: Add tests for maximum path length limitation. https://gitlab.winehq.org/wine/wine/-/merge_requests/7540

2 6

Re: [PATCH v4 0/6] MR8326: ntdll: Implement RtlActivateActivationContextUnsafeFast().
by Nikolay Sivov (＠nsivov) June 18, 2025

June 18, 2025

Nikolay Sivov (@nsivov) commented about dlls/ntdll/actctx.c: > +/****************************************************************** > + * RtlDeactivateActivationContextUnsafeFast (NTDLL.@) > + * > + * FIXME: function prototype might be wrong > + */ > +VOID FASTCALL RtlDeactivateActivationContextUnsafeFast( RTL_CALLER_ALLOCATED_ACTIVATION_CONTEXT_STACK_FRAME_EXTENDED *frame_extended ) > +{ > + ACTIVATION_CONTEXT_STACK *actctx_stack = NtCurrentTeb()->ActivationContextStackPointer; > + ACTIVATION_CONTEXT *actctx; > + > + TRACE( "%p\n", frame_extended ); > + > + actctx = actctx_stack->ActiveFrame->ActivationContext; > + actctx_stack->ActiveFrame = frame_extended->Frame.Previous; > + RtlReleaseActivationContext( actctx ); > +} Should we check anything here? For example ActiveFrame could be null or it could be that ActiveFrame != &frame_extended->Frame. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8326#note_107024

1 0

Re: [PATCH v4 0/6] MR8326: ntdll: Implement RtlActivateActivationContextUnsafeFast().
by Nikolay Sivov (＠nsivov) June 18, 2025

June 18, 2025

Nikolay Sivov (@nsivov) commented about dlls/kernelbase/loader.c: > */ > BOOL WINAPI DECLSPEC_HOTPATCH GetCurrentActCtx( HANDLE *pcontext ) > { > - return set_ntstatus( RtlGetActiveActivationContext( pcontext )); > + struct _ACTIVATION_CONTEXT *actctx; > + NTSTATUS status; > + > + status = RtlGetActiveActivationContext( &actctx ); > + if (status == STATUS_SUCCESS) > + *pcontext = actctx; > + return set_ntstatus( status ); > } I think you can just cast to "struct _ACTIVATION_CONTEXT *" here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8326#note_107021

1 0

[PATCH 0/5] MR8340: widl: Add rows for propget methods.
by Hans Leidekker (＠hans) June 18, 2025

June 18, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8340

3 13

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Zhiyi Zhang (＠zhiyi) June 18, 2025

June 18, 2025

On Wed Jun 18 08:29:18 2025 +0000, Nikolay Sivov wrote: > This will change behavior for all the tests. We can create this file > dynamically as an external manifest, then restart as a child process. Right. That would be better. Let's do that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106999

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Nikolay Sivov (＠nsivov) June 18, 2025

June 18, 2025

On Wed Jun 18 08:27:27 2025 +0000, Zhiyi Zhang wrote: > I see. In that case, you can leave it and keep the longPathAware > manifest in the kernel32 test resource. This will change behavior for all the tests. We can create this file dynamically as an external manifest, then restart as a child process. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106998

1 0