- Wine-GitLab - list.winehq.org

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Yongjie Yao (＠yaoyongjie) June 17, 2025

June 17, 2025

On Mon Jun 16 10:56:00 2025 +0000, Zhiyi Zhang wrote: > Add a new line. ok. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106974

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Yongjie Yao (＠yaoyongjie) June 17, 2025

June 17, 2025

On Mon Jun 16 10:56:00 2025 +0000, Zhiyi Zhang wrote: > Same here. ok. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106973

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Yongjie Yao (＠yaoyongjie) June 17, 2025

June 17, 2025

On Mon Jun 16 10:56:00 2025 +0000, Zhiyi Zhang wrote: > `successed` is a typo. Let's use "CopyFileExW(%s, %s) failed, error %lu.\n" ok. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106972

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Yongjie Yao (＠yaoyongjie) June 17, 2025

June 17, 2025

On Mon Jun 16 10:56:00 2025 +0000, Zhiyi Zhang wrote: > You can put ret, type, and size on the same line and initialise size > after RegOpenKeyExA succeeds. ok. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106971

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Yongjie Yao (＠yaoyongjie) June 17, 2025

June 17, 2025

On Mon Jun 16 10:55:59 2025 +0000, Zhiyi Zhang wrote: > Let reorder the conditions to `wcslen(source) >= MAX_PATH && > wcsncmp(source, L"\\\\?\\", 4) && > !RtlGetCurrentPeb()->IsLongPathAwareProcess)`. I find it clearer this way. ok. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106970

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Yongjie Yao (＠yaoyongjie) June 17, 2025

June 17, 2025

On Mon Jun 16 10:55:59 2025 +0000, Zhiyi Zhang wrote: > Change it to "static NTSTATUS (WINAPI > *pRtlGetVersion)(PRTL_OSVERSIONINFOEXW);" for style consistency. ok -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106969

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Yongjie Yao (＠yaoyongjie) June 17, 2025

June 17, 2025

On Mon Jun 16 10:55:59 2025 +0000, Zhiyi Zhang wrote: > Avoid white-space changes. ok. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106968

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Yongjie Yao (＠yaoyongjie) June 17, 2025

June 17, 2025

On Mon Jun 16 10:55:58 2025 +0000, Zhiyi Zhang wrote: > Let's rename them to is_reg_long_path_enabled() and is_manifest_long_path_enabled(). ok. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106967

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Yongjie Yao (＠yaoyongjie) June 17, 2025

June 17, 2025

On Mon Jun 16 10:55:58 2025 +0000, Zhiyi Zhang wrote: > You can use literal Unicode strings. For example, QueryActCtxSettingsW( > 0, NULL, L"http://schemas.microsoft.com/SMI/2016/WindowsSettings", ...) ok. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106966

1 0

Re: [PATCH v2 0/1] MR8353: amstream/tests: Add a few return value checks (Coverity). - approved
by Alexandre Julliard (＠julliard) June 17, 2025

June 17, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8353

1 0