- Wine-GitLab - list.winehq.org

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Zhiyi Zhang (＠zhiyi) June 16, 2025

June 16, 2025

Zhiyi Zhang (@zhiyi) commented about dlls/kernel32/tests/file.c: > SetLastError(0xdeadbeef); > retok = CopyFileExA(long_path_1, long_path_2, NULL, NULL, NULL, 0); > ok(retok, "CopyFileExA failed, got %ld, copy %s -> %s failed\n", GetLastError(), long_path_1, long_path_2); > + Avoid white-space changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106687

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Zhiyi Zhang (＠zhiyi) June 16, 2025

June 16, 2025

Zhiyi Zhang (@zhiyi) commented about dlls/ntdll/actctx.c: > + TRACE("windows version: win %ld, build %ld\n", rovi.dwMajorVersion, rovi.dwBuildNumber); > + } > + else > + { > + ERR("RtlGetVersion failed\n"); > + rovi.dwMajorVersion = 0; > + rovi.dwBuildNumber = 0; > + } > + } > + > + return rovi.dwMajorVersion >= 10 && rovi.dwBuildNumber >= 14393; > +} > + > +NTSTATUS query_dword_option( HANDLE hkey, LPCWSTR name, LONG *value ); > + > +static BOOL is_longpath_enabled_in_reg(void) Let's rename it to is_reg_long_path_enabled() -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106686

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Zhiyi Zhang (＠zhiyi) June 16, 2025

June 16, 2025

Zhiyi Zhang (@zhiyi) commented about dlls/ntdll/actctx.c: > + if (RtlGetVersion(&rovi) == ERROR_SUCCESS) > + { > + TRACE("windows version: win %ld, build %ld\n", rovi.dwMajorVersion, rovi.dwBuildNumber); > + } > + else > + { > + ERR("RtlGetVersion failed\n"); > + rovi.dwMajorVersion = 0; > + rovi.dwBuildNumber = 0; > + } > + } > + > + return rovi.dwMajorVersion >= 10 && rovi.dwBuildNumber >= 14393; > +} > + > +NTSTATUS query_dword_option( HANDLE hkey, LPCWSTR name, LONG *value ); Put this in ntdll_misc.h. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106685

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Zhiyi Zhang (＠zhiyi) June 16, 2025

June 16, 2025

Zhiyi Zhang (@zhiyi) commented about dlls/kernel32/tests/wine_test.manifest: > <?xml version="1.0" encoding="UTF-8" standalone="yes"?> > -<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0"> > - <assemblyIdentity version="1.0.0.0" name="Wine.Test"/> Let's activate this manifest dynamically so that it doesn't affect other tests. For example, you can see kernel32/tests/actctx.c. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106684

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Zhiyi Zhang (＠zhiyi) June 16, 2025

June 16, 2025

Zhiyi Zhang (@zhiyi) commented about dlls/kernel32/tests/file.c: > + SIZE_T size; > + > + if (buffer[0] == 0) > + { > + memset( buffer, 0xcc, sizeof(buffer) ); > + ret = QueryActCtxSettingsW( 0, NULL, namespace2016W, longPathAwareW, buffer, lstrlenW(trueW) + 1, &size ); > + if (ret && size == lstrlenW(trueW) + 1) > + { > + trace("in app manifest LongPathAware: %s\n", debugstr_w(buffer)); > + } > + } > + > + return lstrcmpiW(buffer, trueW) == 0; > +} > + > +static BOOL is_enabled_long_path(void) Let's rename them to is_reg_long_path_enabled() and is_manifest_long_path_enabled(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106683

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Zhiyi Zhang (＠zhiyi) June 16, 2025

June 16, 2025

Zhiyi Zhang (@zhiyi) commented about dlls/kernel32/tests/file.c: > +} > + > +static BOOL is_app_enabled_long_path(void) > +{ > + static WCHAR buffer[10] = { 0 }; > + static const WCHAR *trueW = L"true"; > + static const WCHAR *longPathAwareW = L"longPathAware"; > + static const WCHAR *namespace2016W = L"http://schemas.microsoft.com/SMI/2016/WindowsSettings"; > + > + BOOL ret; > + SIZE_T size; > + > + if (buffer[0] == 0) > + { > + memset( buffer, 0xcc, sizeof(buffer) ); > + ret = QueryActCtxSettingsW( 0, NULL, namespace2016W, longPathAwareW, buffer, lstrlenW(trueW) + 1, &size ); You can use literal Unicode strings. For example, QueryActCtxSettingsW( 0, NULL, L"http://schemas.microsoft.com/SMI/2016/WindowsSettings", ...) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106682

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Zhiyi Zhang (＠zhiyi) June 16, 2025

June 16, 2025

On Wed May 28 14:34:06 2025 +0000, Zhiyi Zhang wrote: > The Windows 10 tests are still failing. Could you investigate that? I see these win10 test failures on other MRs as well. So they're not related to this MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106680

1 0

[PATCH v3 0/5] MR8291: winex11: Drop pixmap-based child window workaround.
by Rémi Bernon June 16, 2025

June 16, 2025

Updating the GL drawables on/offscreen dynamically, similarly to how we do it for Vulkan, and in order to ultimately converge and factor both GL and VK client surfaces. -- v3: winex11: Rename context drawables to draw / read. winex11: Drop pixmap-based child window workaround. winex11: Update drawable size and offscreen when presenting. winex11: Update every window GL drawable on resize / reparent. winex11: Update GL drawable offscreen status instead of recreating. https://gitlab.winehq.org/wine/wine/-/merge_requests/8291

1 6

[PATCH v3 0/2] MR8293: kernelbase: SetFileInformationByHandle pass FileRenameInfoEx to NtSetInformationFile
by Michael Stopa (＠stomy) June 16, 2025

June 16, 2025

FileRenameInfoEx is already handled by NtSetInformationFile, SetFileInformationByHandle need only pass it through correctly. As of version 5.3, Apple's Metal Developer Tools are dependent on SetFileInformationByHandle to handle FileRenameInfoEx in this fashion. -- v3: kernelbase: pass FileRenameInfoEx to NtSetInformationFile kernel32/tests: SetFileInfo should accept FileRenameInfoEx https://gitlab.winehq.org/wine/wine/-/merge_requests/8293

2 3

[PATCH v20 0/3] MR8200: cmd: COPY should output file names as they are copied.
by Joe Souza (＠JoeS209) June 16, 2025

June 16, 2025

In native Windows, the COPY command will display the names of the files as they are copied. Wine should do the same. This change enables that. -- v20: cmd: Allow '+' as delimiter for tab-completion, e.g. 'copy file+file2'. https://gitlab.winehq.org/wine/wine/-/merge_requests/8200

2 4