- Wine-GitLab - list.winehq.org

Re: [PATCH v15 0/3] MR8200: cmd: COPY should output file names as they are copied.
by eric pouech (＠epo) June 12, 2025

June 12, 2025

eric pouech (@epo) commented about programs/cmd/wcmdmain.c: > * Otherwise, parse the buffer to find the last parameter in the buffer, > * where tab was pressed. > */ > - if (len && inputBuffer[len-1] == L' ') { you should support the same parameters as below likely you'd better have the {cc=len; } body when parameter_with_delims() fails -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8200#note_106328

1 0

Re: [PATCH v15 0/3] MR8200: cmd: COPY should output file names as they are copied.
by eric pouech (＠epo) June 12, 2025

June 12, 2025

eric pouech (@epo) commented about programs/cmd/wcmdmain.c: > /* Handle paths here. Find last '\\'. > * If '\\' isn't found then insert pos is the same as search pos. > */ > - while (cc > sc->search_pos && inputBuffer[cc] != L'\\') { ditto is there a reason to not handle the other delimiters here? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8200#note_106327

1 0

Re: [PATCH v15 0/3] MR8200: cmd: COPY should output file names as they are copied.
by eric pouech (＠epo) June 12, 2025

June 12, 2025

eric pouech (@epo) commented about programs/cmd/builtins.c: > } > } > > + if (numcopied) { > + WCHAR* string; > + string = WCMD_format_string(WCMD_LoadMessage(WCMD_NUMCOPIED), numcopied); nitpick: `WCMD_output(WCMD_LoadMessage... `would be simpler -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8200#note_106326

1 0

[PATCH 0/2] MR8293: kernelbase: SetFileInformationByHandle pass FileRenameInfoEx to NtSetInformationFile
by Michael Stopa (＠stomy) June 12, 2025

June 12, 2025

FileRenameInfoEx is already handled by NtSetInformationFile, SetFileInformationByHandle need only pass it through correctly. As of version 5.3, Apple's Metal Developer Tools are dependent on SetFileInformationByHandle to handle FileRenameInfoEx in this fashion. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8293

3 5

[PATCH v3 0/6] MR8254: msi: Fix installing 64 bit library from 32 bit installer if 32 bit version of it is loaded into installer.
by Paul Gofman (＠gofman) June 12, 2025

June 12, 2025

-- v3: msi: Fix getting version info for library loaded into wow64 process. https://gitlab.winehq.org/wine/wine/-/merge_requests/8254

3 8

[PATCH 0/5] MR8291: winex11: Drop pixmap-based child window workaround.
by Rémi Bernon June 12, 2025

June 12, 2025

Updating the GL drawables on/offscreen dynamically, similarly to how we do it for Vulkan, and in order to ultimately converge and factor both GL and VK client surfaces. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8291

1 5

[PATCH 0/1] MR8290: secur32/tests: Fix test failure on Windows 11.
by Hans Leidekker (＠hans) June 12, 2025

June 12, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58190 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8290

2 1

[PATCH v5 0/4] MR8210: win32u: Use a pbuffer instead of OSmesa for memory DCs GL.
by Rémi Bernon June 12, 2025

June 12, 2025

OSmesa is deprecated and has been removed from latest mesa releases, this replaces it with pbuffer rendering and flushing of the surface onto the bitmap at some specific sync points. The tests show that this is roughly how Windows seem to behave anyway, instead of rendering directly to the memory as OSmesa does. -- v5: win32u: Remove now unnecessary context and pbuffer funcs. win32u: Drop now unnecessary OSMesa dependency. win32u: Use a pbuffer to implement GL on memory DCs. opengl32: Flush the contexts on gl(Draw|Read)Pixels and glViewport. https://gitlab.winehq.org/wine/wine/-/merge_requests/8210

1 5

[PATCH 0/1] MR8289: win32u: Fix copy of vulkan surfaces list on window destruction.
by Rémi Bernon June 12, 2025

June 12, 2025

Fixes: 5e4d40dddc3492bd48c6f0b042c581022d4ca9fc This actually manifested with a timeout in the quartz:filtergraph 32bit tests which I overlooked. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8289

1 1

Re: [PATCH v2 0/5] MR8281: amstream: More fallout from dynamic format change.
by Rémi Bernon June 12, 2025

June 12, 2025

Fwiw this breaks the tests on Windows: https://test.winehq.org/data/patterns.html#amstream:amstream -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8281#note_106304

1 0