- Wine-GitLab - list.winehq.org

Re: [PATCH v6 0/1] MR8073: ntdll: Unbreak new wow64 mode on FreeBSD.
by Alexander Shaikhulin (＠shkhln) May 22, 2025

May 22, 2025

On Thu May 22 22:07:54 2025 +0000, Alexander Shaikhulin wrote: > (32-bit FreeBSD apps on amd64 don't run into this issue because they use > int 0x80 / iret.) This is the most concise explanation that I found: https://github.com/torvalds/linux/blob/a11a72229881d8ac1d52ea727101bc9c7441…. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8073#note_104276

1 0

[PATCH v3 0/1] MR8125: mscoree: Add missing NUL terminator.
by Yuxuan Shui (＠yshui) May 22, 2025

May 22, 2025

Fix out-of-bound access by wcslen. Found by ASan. -- v3: mscoree: Add missing NUL terminator. https://gitlab.winehq.org/wine/wine/-/merge_requests/8125

2 2

[PATCH 0/1] MR8125: mscoree: Add missing NUL terminator.
by Yuxuan Shui (＠yshui) May 22, 2025

May 22, 2025

Fix out-of-bound access by wcslen. Found by ASan. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8125

2 1

Re: [PATCH v6 0/1] MR8073: ntdll: Unbreak new wow64 mode on FreeBSD.
by Alexander Shaikhulin (＠shkhln) May 22, 2025

May 22, 2025

On Thu May 22 21:42:35 2025 +0000, Alexandre Julliard wrote: > Please keep the Linux and FreeBSD case separate, unless they are truly identical. Done. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8073#note_104269

1 0

[PATCH v5 0/1] MR8073: ntdll: Unbreak new wow64 mode on FreeBSD.
by Alexander Shaikhulin (＠shkhln) May 22, 2025

May 22, 2025

1. For %fs/fsbase the patch follows the macOS logic with LDT descriptor registration and Linux with switching. One notable difference is that on 32->64 transition we set %fs to GSEL(GUFS32_SEL, SEL_UPL) before restoring fsbase, otherwise FreeBSD will just revert it by reloading the selector [at the first opportunity](https://github.com/freebsd/freebsd-src/blob/5673462af5330df207…. GSEL(GUFS32_SEL, SEL_UPL) is the default %fs value on FreeBSD and is special-cased to save/restore actual fsbase value to/from PCB. 2. I was told we could get rid of fsbase glitches in signal handlers by blocking signals with [sigfastblock(2)](https://man.freebsd.org/cgi/man.cgi?query=sigfastblock) between %fs reset to the default value and fsbase reset to pthread_teb. This is currently a part of internal API for libthr, which could be exposed as pthread_signal_block_np for Wine. I'm on the fence whether it's worth it. 3. I fully admit I have no idea what registers are worth preserving around fallback sysarch(AMD64_SET_FSBASE) syscalls and whether it's appropriate to push those registers to stack. ("Kernel" stack should be fine, I assume?) Syscalls definitely clobber r8-r11. 4. For %ss see https://lkml.org/lkml/2015/4/24/216. FreeBSD doesn't have a similar workaround in the kernel, so it goes into Wine. -- v5: ntdll: Unbreak new wow64 mode on FreeBSD. https://gitlab.winehq.org/wine/wine/-/merge_requests/8073

2 1

[PATCH v4 0/1] MR8073: ntdll: Unbreak new wow64 mode on FreeBSD.
by Alexander Shaikhulin (＠shkhln) May 22, 2025

May 22, 2025

1. For %fs/fsbase the patch follows the macOS logic with LDT descriptor registration and Linux with switching. One notable difference is that on 32->64 transition we set %fs to GSEL(GUFS32_SEL, SEL_UPL) before restoring fsbase, otherwise FreeBSD will just revert it by reloading the selector [at the first opportunity](https://github.com/freebsd/freebsd-src/blob/5673462af5330df207…. GSEL(GUFS32_SEL, SEL_UPL) is the default %fs value on FreeBSD and is special-cased to save/restore actual fsbase value to/from PCB. 2. I was told we could get rid of fsbase glitches in signal handlers by blocking signals with [sigfastblock(2)](https://man.freebsd.org/cgi/man.cgi?query=sigfastblock) between %fs reset to the default value and fsbase reset to pthread_teb. This is currently a part of internal API for libthr, which could be exposed as pthread_signal_block_np for Wine. I'm on the fence whether it's worth it. 3. I fully admit I have no idea what registers are worth preserving around fallback sysarch(AMD64_SET_FSBASE) syscalls and whether it's appropriate to push those registers to stack. ("Kernel" stack should be fine, I assume?) Syscalls definitely clobber r8-r11. 4. For %ss see https://lkml.org/lkml/2015/4/24/216. FreeBSD doesn't have a similar workaround in the kernel, so it goes into Wine. -- v4: ntdll: Unbreak new wow64 mode on FreeBSD. https://gitlab.winehq.org/wine/wine/-/merge_requests/8073

3 8

Re: [PATCH v2 0/5] MR8123: winex11: Track _MOTIF_WM_HINTS property in the window state. - approved
by Alexandre Julliard (＠julliard) May 22, 2025

May 22, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8123

1 0

Re: [PATCH v2 0/1] MR8119: odbc32: Destroy child objects automatically on successful SQLDisconnect(). - approved
by Alexandre Julliard (＠julliard) May 22, 2025

May 22, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8119

1 0

Re: [PATCH v2 0/2] MR8118: masdo15: Add connection_OpenSchema implementation. - approved
by Alexandre Julliard (＠julliard) May 22, 2025

May 22, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8118

1 0

Re: [PATCH v2 0/1] MR8113: libs/ldap: Save server attributes also on 2nd authentication step. - approved
by Alexandre Julliard (＠julliard) May 22, 2025

May 22, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8113

1 0