- Wine-GitLab - list.winehq.org

[PATCH 0/1] MR8113: libs/ldap: Save server attributes also on 2nd authentication step.
by Dmitry Timoshkov (＠dmitry) May 22, 2025

May 22, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8113

3 2

[PATCH 0/1] MR8117: Revert "winex11: Focus the desktop window when _NET_ACTIVE_WINDOW is None."
by Rémi Bernon May 22, 2025

May 22, 2025

This reverts commit b1f74bc20d75592217add533f4630e163ec76075. Although this was thoroughly tested on Mutter and Kwin with Proton, @alesliehughes reported some issues with it breaking Steam for Windows under some setup, and test results from tonight seem to indicate that it also triggers undesired focus changes, when foreground is only transient and about to change to another window, with Openbox and Fvwm: https://test.winehq.org/data/8f91df4c4e4fb8b32c737bb02e82dcddfb71a114/linux… https://test.winehq.org/data/8f91df4c4e4fb8b32c737bb02e82dcddfb71a114/linux… The problem is that Openbox is not developed anymore, so it is hopeless to imagine changing anything there. And the Fvwm version used in the testbot is `fvwm2`, in a similar development state, although we might decide to switch to a more recent fvwm3 later on it has its own issues as the `linux_rbernon-x11-trixie` test VMs show. Under XWayland, the only indication that a Wayland window is being focused is `_NET_ACTIVE_WINDOW = None`/FocusOut event, which are indistinguishable from these transient focus changes. I'm now trying to make some changes on XWayland WM side, by focusing the root window instead so we can tell the difference, but it's not clear whether this will be well received or not for the moment: * https://gitlab.freedesktop.org/wayland/weston/-/merge_requests/1761 * https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/5076 * https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/4447 * https://invent.kde.org/plasma/kwin/-/merge_requests/7664 In the meantime we should probably revert this in order to fix the regression and avoid introducing spurious failures again. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8117

1 1

Re: [PATCH v7 0/3] MR8020: libs/ldap: Make GSS-SPNEGO SASL plugin work with LDAP server that uses Kerberos authentication.
by Hans Leidekker (＠hans) May 22, 2025

May 22, 2025

On Thu May 22 12:41:19 2025 +0000, Dmitry Timoshkov wrote: > I was mentioning the part about using SECBUFFER_STREAM in > DecryptMessage(). It was my guess that EncryptMessage() is supposed to > support the mirroring logic of using SECBUFFER_DATA as input and > SECBUFFER_STREAM as output buffers. That was my first guess too :) Perhaps I'm missing something but this appears to encrypt in-place. It seems to me that you would need to pass a separate SECBUFFER_STREAM buffer that is large enough to hold data + token. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8020#note_104208

1 0

Re: [PATCH v7 0/3] MR8020: libs/ldap: Make GSS-SPNEGO SASL plugin work with LDAP server that uses Kerberos authentication.
by Dmitry Timoshkov (＠dmitry) May 22, 2025

May 22, 2025

On Thu May 22 12:32:42 2025 +0000, Hans Leidekker wrote: > They don't pass a SECBUFFER_STREAM buffer in that sample. I was mentioning the part about using SECBUFFER_STREAM in DecryptMessage(). It was my guess that EncryptMessage() is supposed to support the mirroring logic of using SECBUFFER_DATA as input and SECBUFFER_STREAM as output buffers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8020#note_104207

1 0

Re: [PATCH v7 0/3] MR8020: libs/ldap: Make GSS-SPNEGO SASL plugin work with LDAP server that uses Kerberos authentication.
by Hans Leidekker (＠hans) May 22, 2025

May 22, 2025

On Thu May 22 11:10:27 2025 +0000, Dmitry Timoshkov wrote: > Why not? EncryptMessage() would get SECBUFFER_DATA as input and > SECBUFFER_STREAM as output buffers. They don't pass a SECBUFFER_STREAM buffer in that sample. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8020#note_104206

1 0

[PATCH v5 0/3] MR8078: windows.ui: Fix a double free.
by Zhiyi Zhang (＠zhiyi) May 22, 2025

May 22, 2025

The object reference is actually held by ref_weak. -- v5: geolocation: Use helpers to implement IWeakReference. windows.ui: Use helpers to implement IWeakReference. https://gitlab.winehq.org/wine/wine/-/merge_requests/8078

4 5

Re: [PATCH v7 0/3] MR8020: libs/ldap: Make GSS-SPNEGO SASL plugin work with LDAP server that uses Kerberos authentication.
by Dmitry Timoshkov (＠dmitry) May 22, 2025

May 22, 2025

On Thu May 22 11:10:27 2025 +0000, Hans Leidekker wrote: > Yes, I had seen that. Note that it wouldn't make the issue of buffer > layout > differences between NTLM and Kerberos go away for EncryptMessage(). Why not? EncryptMessage() would get SECBUFFER_DATA as input and SECBUFFER_STREAM as output buffers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8020#note_104199

1 0

Re: [PATCH v7 0/3] MR8020: libs/ldap: Make GSS-SPNEGO SASL plugin work with LDAP server that uses Kerberos authentication.
by Hans Leidekker (＠hans) May 22, 2025

May 22, 2025

Yes, I had seen that. Note that it wouldn't make the issue of buffer layout differences between NTLM and Kerberos go away for EncryptMessage(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8020#note_104198

1 0

Re: [PATCH v7 0/3] MR8020: libs/ldap: Make GSS-SPNEGO SASL plugin work with LDAP server that uses Kerberos authentication.
by Dmitry Timoshkov (＠dmitry) May 22, 2025

May 22, 2025

Just in case this could be useful during further improvements: https://learn.microsoft.com/en-us/windows/win32/secauthn/sspi-kerberos-inte… suggests that continuous buffer encrypted by gss_wrap() could be decrypted by passing buffer with type SECBUFFER_STREAM to DecryptMessage(). Since neither dlls/msv1_0 (NTLM) nor dlls/kerberos support SECBUFFER_STREAM current approach with detecting security package and manually constructing data/token buffers is a working solution. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8020#note_104197

1 0

[PATCH v2 0/6] MR7932: mf: Restart transforms and sinks on seek.
by Brendan McGrath (＠redmcg) May 22, 2025

May 22, 2025

This MR fixes seek in VRChat by copying the sequence of flushes/stop/starts that Windows does. The order on Windows is: 1. Stop sources; 2. Flush MFTs; 3. Start sources; 4. Request output down the chain of sink inputs; 6. Flush sinks; and 7. Start the clock This takes place whether we pause before we seek or seek without pause. Changes in version 2: 1. Add test to see when SAR requests new samples; 2. Add test to examine when step 4 from above takes place; 3. Adjust the seek implementation in `mf/session.c` to match findings from the new tests 4. Adjust `mfmediaengine` to reflect findings from the new tests -- v2: mfmediaengine: Request sample if we are seeking. mfmediaengine: Don't perform implicit flush on state change. mf: Don't send MFT_MESSAGE_NOTIFY_START_OF_STREAM when seeking. mf: Restart transforms and sinks on seek. mf/tests: Test sequence of calls during a Pause and Seek. mf/tests: Test when SAR requests a new sample. https://gitlab.winehq.org/wine/wine/-/merge_requests/7932

3 10