March 5, 2026
10:10 p.m.
Ideally we probably want to get a buffer and complete the copying in one operation with the parser mutex locked, but that doesn't look practical. Or, the `wg_parser_stream_get_buffer()` return struct could include the GstBuffer and map info to be released later on the unix side, but it wouldn't make much sense to continue copying the buffer after a flush. Another issue is `offset += advance` occurs even if copying failed because `buffer` is null or, after this patch, because it is new. Perhaps `send_sample` should return S_FALSE in that case so we can elide offset advancement, but I don't know enough about quartz to be sure. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10256