Re: [PATCH v2 0/5] MR4092: user32: Actually implement RealGetWindowClass{A/W}.

[Jinoh Kang (＠iamahuman)]

Jinoh Kang (@iamahuman) commented about dlls/win32u/window.c:
> return TRUE;
>  }
>
> +static BOOL set_real_window_class_id( HWND hwnd, DWORD param )
> +{
> +    WND *win = get_win_ptr( hwnd );
> +
> +    if (!win || win == WND_OTHER_PROCESS || win == WND_DESKTOP)
> +    {
> +        ERR("Can't set real window class for a window belonging to another process\n");
> +        return FALSE;
> +    }

This code path is not tested, so it's not clear if this behavior matches that of Windows (current and future versions).

You should either test that cross-process NtUserSetRealClassId always fails, or convert the ERR to FIXME:
```suggestion:-0+0
    if (!win) return FALSE;
    if (win == WND_OTHER_PROCESS || win == WND_DESKTOP)
    {
        FIXME("Can't set real window class for a window belonging to another process\n");
        return FALSE;
    }
```

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4092#note_48704