Re: [PATCH v9 0/7] MR443: tests: Add some tests for effects groups syntax.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/vkd3d_shader_main.c:
> -void set_u32(struct vkd3d_bytecode_buffer *buffer, size_t offset, uint32_t value)
> +size_t bytecode_reserve_bytes(struct vkd3d_bytecode_buffer *buffer, size_t size)
> +{
> +    size_t offset = bytecode_align(buffer);
> +
> +    if (buffer->status)
> +        return offset;
> +
> +    if (!vkd3d_array_reserve((void **)&buffer->data, &buffer->capacity, offset + size, 1))
> +    {
> +        buffer->status = VKD3D_ERROR_OUT_OF_MEMORY;
> +        return offset;
> +    }
> +
> +    memset(buffer->data + offset, 0xcd, size);

I'd rather initialize to zero, unless some kind of development flag is set.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/443#note_52142