Re: [PATCH v2 0/1] MR10348: ntdll: Avoid expensive inverted DST check on get_timezone_info() cache hit path

[Paul Gofman (＠gofman)]

Paul Gofman (@gofman) commented about dlls/ntdll/unix/system.c:
> return;
>      }
>
> +    tm1 = tm2 = *tm;
> +    tm1.tm_isdst = 0;
> +    tm2.tm_isdst = 1;
> +    inverted_dst = mktime(&tm1) < mktime(&tm2);
> +    current_bias = bias;

that doesn't affect functionality, but for better readability I'd suggest to keep assigning current_year and current_bias together and not split those across the code. Also probably move those assignments right after the 'if' checking those, before 
'tm1 = tm2= *tm;'.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10348#note_132386