Nov. 9, 2023
8:48 p.m.
On Thu Nov 9 19:54:27 2023 +0000, Zebediah Figura wrote:
This doesn't include any of the validity checks for packoffset(). Should it? We don't have tests for this. We have validate_buffer_offsets() to perform this check already.
I think that the first test added to register-reserations.shader_test already covers this, when run for SM4: ``` [pixel shader fail(sm<6) todo] // Overlapping register(cX) reservations should only be allowed on SM6. float a : register(c0); float b : register(c0); float4 main() : sv_target { return a + b; } ``` -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/458#note_51865