June 17, 2025
7:51 p.m.
On Tue Jun 17 19:51:01 2025 +0000, Elizabeth Figura wrote:
I won't reject this, but that was kind of an intentional choice, taking it as a given that GetDirectDraw() will succeed there, and avoiding an unnecessary line since it's not the point of the test. Is Coverity really warning about every unchecked HRESULT? That seems surprising; there's quite a lot in Wine. Here it warns because there is 14 calls of the same function, but 2 of them are different. I think it makes sense, you either test for it everywhere or don't test it at all.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8353#note_106901