On Wed Mar 4 23:07:30 2026 +0000, Craig Schulstad wrote:
All, Per the suggestion to squash down the commits, I did that, and I was able to successfully get the commit to do all of the successful builds. And, all of the testing was passed except the "test-linux-32" set. Previously, I had hundreds of failures in this test, but now it appears to be reduced down to two issues. The first one has to do with a "LoadStringA" test in the user32/resource.c module. user32:resource start dlls/user32/tests/resource.c resource.c:216:0.025 Test failed: GetLastError() = 126 The second issue has to do with an environment edit function in the win32u/win32u.c module. win32u:win32u start dlls/win32u/tests/win32u.c win32u.c:357:0.214 Test marked todo: NtUserGetProp returned 0 win32u.c:361:0.214 Test marked todo: NtUserGetProp returned 0 win32u.c:386:0.214 Test marked todo: NtQueryInformationAtom returned 0xc000000d win32u.c:393:0.214 Test marked todo: NtUserGetProp returned 00000000 win32u.c:396:0.214 Test marked todo: NtQueryInformationAtom returned 0xc000000d win32u.c:448:0.217 Test failed: 0xc010: L"EditEnvItems": buf = L"cc71578f-a78f-4953-89fd-43711041beee" I honestly don't know if these are issues arising from my enhancement in kernelbase/loader.c or if these are issues being caused by other commits in this set. First off, can someone tell me what error code "126" refers to, as I could follow the path of the string load function calling the resource search function which is a function I did enhance. Thanks in advance. Regards, Craig You mean https://gitlab.winehq.org/wine/wine/-/pipelines/59189 in MR !10227? Yes, you've successfully deleted the merge commits from that one. That's progress.
126 is ERROR_MOD_NOT_FOUND, most likely from your new LoadLibraryExW call. You should GetLastError() before that call, and RestoreLastError() afterwards. I'm not sure about the win32u one. We have a bunch of tests that fail at random (yes, they're a pain), but I'm not familiar enough with that part of Wine to determine if that's one of the unstable ones, or if it's due to your changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10209#note_131335