Re: [PATCH v21 0/9] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.

[Jinoh Kang (＠iamahuman)]

On Tue Feb 20 13:08:45 2024 +0000, Jinoh Kang wrote:
> `session_mapping` should be treated as a reference.
> ```suggestion:-0+0
>     session_mapping = (struct mapping *)grab_object( &mapping->obj );
> ```
> Is there a reason this is not yet addressed? If you don't like the extra ref, I think it's better to force `(attr & OBJ_PERMANENT) != 0`, by either:

```diff
+    assert(attr & OBJ_PERMANENT); // ensure attr is permanent
```

or

```diff
-                                       unsigned int attr, const struct security_descriptor *sd )
+                                       const struct security_descriptor *sd ) // don't let caller supply attr
```

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3103#note_63181