Re: [PATCH v5 0/1] MR384: vkd3d: Replace the descriptor object cache with a thread-local implementation.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d/vkd3d_private.h:
> +    if (rc < 0)
> +    {
> +        ERR("Failed to allocate TLS key, rc %d.\n.", rc);
> +        return false;
> +    }
> +    return true;
>  }
>
> -static inline int vkd3d_tls_key_set_value(const struct vkd3d_tls_key *key, void *value)
> +static inline bool vkd3d_tls_key_set_value(const struct vkd3d_tls_key *key, void *value)
>  {
> -    return pthread_setspecific(key->key, value);
> +    int rc = pthread_setspecific(key->key, value);
> +    if (rc < 0)
> +    {
> +        ERR("Failed to set TLS key value, rc %d.\n.", rc);
> Wrong error message.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/384#note_48799