Re: [PATCH v8 0/5] MR9112: XCOPY and COPY should not attempt to copy a file to itself.

[eric pouech (＠epo)]

eric pouech (@epo) commented about programs/xcopy/xcopy.c:
> }
>              }
>
> +            /* Don't copy a file over itself. */
> +            if (XCOPY_IsSameFile(copyFrom, copyTo)) {
> +                skipFile = quitCopy = TRUE;
> +                if (!(flags & OPT_QUIET)) {
> +                    if (flags & OPT_FULL)
> +                        XCOPY_wprintf(L"%1 -> %2\n", copyFrom, copyTo);

and this code duplication rather suggests that this should be integrated in the rest of the flow, rather than inserting a new blob of code, which will make things harder to maintain

note that /L does report that the files are identical

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9112#note_120277