Feb. 16, 2024
8:07 p.m.
Jinoh Kang (@iamahuman) commented about dlls/kernel32/tests/pipe.c:
#define test_signaled(h) _test_signaled(__LINE__,h) static void _test_signaled(unsigned line, HANDLE handle) { - DWORD res = WaitForSingleObject(handle, 0); + DWORD res = WaitForSingleObject(handle, 50); (while I don't see 50ms is something risky in such a case, doing that 1000ms also won't hurt).
Right, it isn't risky when run standalone. My main concern is that with testbot batch/concurrent runs, (k)vm threads randomly starve for an arbitrarily amount of time, resulting in spurious failures. Scheduler issue or not, this is probably not going to be fixed anytime soon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5091#note_61568