Jacek Caban (@jacek) commented about dlls/vbscript/global.c:
start = 0;
len = SysStringLen(string); + + if(!len) { + bounds.lLbound = 0; + bounds.cElements = 0; + sa = SafeArrayCreate(VT_VARIANT, 1, &bounds); + if(!sa) { + hres = E_OUTOFMEMORY; + goto error;
This goto is redundant, "goto done" in the following statement already handles that case. Also, instead of creating two identical labels, please rename the existing one. Could you also update the commit message to follow the Wine style guidelines? The subject should start with a capitalized "Split" and end with a period. When referencing Bugzilla, please use the "Wine-Bug: " tag. See git log for examples. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10309#note_131981