Re: [PATCH v9 0/7] MR443: tests: Add some tests for effects groups syntax.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl_codegen.c:
> return VKD3D_ERROR_INVALID_ARGUMENT;
>      }
>  }
> +
> +int hlsl_emit_effect_binary(struct hlsl_ctx *ctx, struct vkd3d_shader_code *out)

Maybe this belongs to `fx.c`?

Also, I don't know if we have a hard policy, but I prefer commit subjects in verbal form rather than nominal. So something like "Add support for..." rather than "Support for...".

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/443#note_52141