Gabriel Ivăncescu (@insn) commented about dlls/mshtml/tests/events.c:
IHTMLWindow2_Release(child);
hres = IHTMLXMLHttpRequestFactory_create(xhr_factory, &xhr); - todo_wine ok(hres == S_OK, "create failed: %08lx\n", hres); IHTMLXMLHttpRequestFactory_Release(xhr_factory); if(hres == S_OK) IHTMLXMLHttpRequest_Release(xhr);
Just a small nitpick, I'd remove this `if(hres == S_OK)` here, since it shouldn't fail now. Other than that LGTM. I also tested it for leaks because I'm paranoid. I found one interesting bit on native, that's probably not important for us, but seeing as I wasted time testing it I want to share it. Looks like native XHR keeps a dangling ref to the outer window and crashes in `create` if outer window is dead (not with a NULL, but actual invalid memory access on freed memory). But not important to replicate. Thankfully the current test keeps it alive so it's not flaky. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4444#note_52914