Piotr Caban (@piotr) commented about dlls/msvcrt/tests/environ.c:
ok( count + 1 == env_get_entry_countA( *p_environ ), "Unexpected count\n" ); ok( _putenv( "__winetest_dog=" ) == 0, "Couldn't reset env var\n" ); ok( count == env_get_entry_countA( *p_environ ), "Unexpected count\n" ); + + /* in putenv, only changed variable is updated (no other reload of kernel info is done) */ + ok( _putenv( "__winetest_duck=" ) == 0, "Couldn't reset env var\n" ); + ok( _putenv( "__winetest_elephant=" ) == 0, "Couldn't reset env var\n" );
It's a minor thing but I think it's better to limit number of environment variables that are used in test, please reuse `__winetest_{dog,cat}` here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4313#note_51519