Feb. 26, 2024
10:38 p.m.
On Mon Feb 26 22:16:33 2024 +0000, Zebediah Figura wrote: > > I see that in early 2022, there were a lot of cleanup patches related > to misleading indentation. While a lot of it was just indentation of > todo_wine, I did a see a few that actually improved that code, and > possibly caught a few bugs. > Which ones are you referring to? > Through a brief search I found *one* commit that actually changed > behaviour, namely ac1628c9d6. Maybe two others I found were even a > visual improvement (08306780d, a51e20f5e0), though those weren't from > 2022. The rest were mostly todo_wine, and the ones that weren't were > really debatably even an improvement. I hadn't looked through them all, but I think they were pretty much the ones you found. I think a44794af may have been an improvement too. Missed that some of those were older (though still probably caught by the flag). I guess I don't really mind removing the flag, but I would say it has had _some_ value (if rather small), and at least I don't think fixing the 'false positives' made the code any worse. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5148#note_62763