Re: [PATCH v8 0/2] MR8459: urlmon: Add PersistentZoneIdentifier semi-stub

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/urlmon/zone_id.c:
> +
> +    hfile = CreateFileW(file_name, GENERIC_READ | GENERIC_WRITE,
> +        FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE, NULL, OPEN_ALWAYS,
> +        FILE_ATTRIBUTE_NORMAL, NULL);
> +    if (hfile == INVALID_HANDLE_VALUE)
> +        return HRESULT_FROM_WIN32(GetLastError());
> +
> +    CloseHandle(hfile);
> +
> +    if (remember)
> +    {
> +        new_file_name = wcsdup(file_name);
> +        if (!new_file_name)
> +            return E_OUTOFMEMORY;
> +
> +        if (This->save_file_name)
> Same here, no need for the NULL check.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8459#note_109923