Matteo Bruni (@Mystral) commented about dlls/dsound/mixer.c:
return count; }
+/** + * Note that this function will overwrite up to fir_width - 1 frames before and + * after the output array. + */
As usual, and in general, please correct me if I'm wrong. This comment is very helpful, but maybe it could be expanded further, here and through additional comments below. With the new downsample algorithm both the "before" and the "after" parts are eventually thrown away (since they're incomplete, the samples in those areas miss some to almost all their partial input contributions), with the "after" part of channel `c`'s `output` buffer overlapping the "before" of channel `c + 1`. For this one I'd just perhaps turn that "output" into "output[]" to clarify that the comment is referring to the output input parameter, rather than e.g. the overall resampler output. It's a very minor change either way, feel free to ignore it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10255#note_132191