Re: [PATCH v8 0/1] MR5373: shell32: Implement FCIDM_SHVIEW_CREATELINK

[Sven Baars (＠sbaars)]

Sven Baars (@sbaars) commented about dlls/shell32/shlview_cmenu.c:
> +    ITEMIDLIST *full_pidl;
> +    HRESULT hr;
> +    int length;
> +    int counter = 1;
> +
> +    static const WCHAR *shortcutW = L"Shortcut";
> +
> +    if (FAILED(IShellLink_Constructor(NULL, &IID_IShellLinkW, (LPVOID*)&shelllink)))
> +    {
> +        ERR("couldn't create ShellLink object\n");
> +        return;
> +    }
> +    full_pidl = ILCombine(This->pidl, This->apidl[0]);
> +    if (!full_pidl)
> +    {
> +        ERR("Out of Memory\n");
> Why don't we just return an `HRESULT` here and return that from `ItemMenu_InvokeCommand`, instead of the verbose ERRs?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5373#note_121806