Feb. 17, 2024
12:14 a.m.
Jinoh Kang (@iamahuman) commented about dlls/kernel32/tests/pipe.c:
#define test_signaled(h) _test_signaled(__LINE__,h) static void _test_signaled(unsigned line, HANDLE handle) { - DWORD res = WaitForSingleObject(handle, 0); + DWORD res = WaitForSingleObject(handle, 50); ok_(__FILE__,line)(res == WAIT_OBJECT_0, "WaitForSingleObject returned %lu\n", res); } This relaxes unaffected tests (e.g., testing if `CreateNamedPipeA()` returns a handle that is initially signaled). I think we should either add a timeout param or introduce a new "wait signaled" helper.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5091#note_61551