Re: [PATCH v3 0/4] MR2091: windows.media.speech: Initial Unixlib work.

[Rémi Bernon]

Rémi Bernon (@rbernon) commented about dlls/windows.media.speech/vosk.c:
> +#include "ntstatus.h"
> +#define WIN32_NO_STATUS
> +#include "winerror.h"
> +#include "winternl.h"
> +
> +#include "wine/debug.h"
> +
> +#include "unixlib.h"
> +
> +WINE_DEFAULT_DEBUG_CHANNEL(vosk);
> +
> +#ifdef HAVE_VOSK_API_H
> +
> +#ifdef SONAME_LIBVOSK
> +static void *libvosk_handle;
> +#endif /* SONAME_LIBVOSK */
> I think you should guard these with `SONAME_LIBVOSK`, instead of `HAVE_VOSK_API_H`. It would save you the `#ifdef` below in vosk_process_attach.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2091#note_22794