Re: [PATCH v7 0/2] MR3151: widl: Prevent infinite loop when structure contains array of itself

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about tools/widl/typegen.c:
> const var_t *field;
> +
> +        if (!visited_structs->structs)
> +        {
> +            visited_structs->count = 0;
> +            visited_structs->capacity = 100;
> +            visited_structs->structs = xmalloc(sizeof (type_t*) * visited_structs->capacity);
> +        }
> +
> +        if (visited_structs->count >= visited_structs->capacity)
> +        {
> +            visited_structs->capacity *= 2;
> +            visited_structs->structs = xrealloc(visited_structs->structs, sizeof (type_t*) * visited_structs->capacity);
> +        }
> +
> +        visited_structs->structs[visited_structs->count] = type;

Setting this before searching the array doesn't look right.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3151#note_52797