On Fri Mar 20 13:57:42 2026 +0000, Jacek Caban wrote:
Sorry that some MRs take longer than others to get to. I'd like to see this bug fixed the most as well, but it is also a tricky one for me to review. It has been a long time since I worked on vbscript, so I need to relearn the code in the process. Overall, the patch is doing a lot of logic in the lexer that really belongs in the parser. This is already true with the existing hack, but extending it this much further does not seem right to me. I know that it is tricky, which is why we have the hack, but as your tests show, such hacks tend to push problems into corner cases rather than being a complete solution. My preference would be to handle this in the parser, even if it means more invasive changes there. If that is not feasible, at least let us try to keep the special-casing to a minimum. I think this can maybe be solved on the parser side but with a lot more duplication. The current result is what I ended up with after many iterations. It's also already validated and in use on the vpinball project.
I fear that some of these issues just don't have a clean solution. But I can have another go on the parser side. Maybe in a different MR with the same tests. Then we can compare. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10244#note_133030