Re: [PATCH v15 0/5] MR514: tests: Use the vulkan runner to run SM1 compilation tests.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/spirv.c:
> enum vkd3d_result result = VKD3D_OK;
>      unsigned int i;
>
> -    if (parser->shader_desc.temp_count)
> -        spirv_compiler_emit_temps(compiler, parser->shader_desc.temp_count);
> -    if (parser->shader_desc.ssa_count)
> -        spirv_compiler_allocate_ssa_register_ids(compiler, parser->shader_desc.ssa_count);
> -

Ha, there are at least three currently open MRs conflicting on this bit! :-)

I'd suggest to go the way Conor and I did, i.e., rather move `vkd3d_shader_normalise()` to the top than moving this down.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/514#note_57884