Re: [PATCH v2 0/7] MR5666: d3dx9: Introduce d3dx_resource structures for use in code sharing.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/surface.c:
> {
> +        uint32_t uncompressed_row_pitch, uncompressed_slice_pitch;
>          const struct pixel_format_desc *uncompressed_desc;
> -        uint32_t uncompressed_row_pitch;
>          void *uncompressed_mem = NULL;
>
> hr = d3dx_pixels_decompress(src_pixels, src_desc, FALSE, &uncompressed_mem, &uncompressed_row_pitch,
> -                &uncompressed_desc);
> +                &uncompressed_slice_pitch, &uncompressed_desc);
>          if (SUCCEEDED(hr))
>          {
>              struct d3dx_pixels uncompressed_pixels;
>
> -            d3dx_pixels_init((const void *)uncompressed_mem, uncompressed_row_pitch, 0, NULL, uncompressed_desc->format,
> -                    0, 0, src_pixels->width, src_pixels->height, 0, src_pixels->depth, &uncompressed_pixels);
> +            d3dx_pixels_init((const void *)uncompressed_mem, uncompressed_row_pitch,

That cast shouldn't be necessary.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5666#note_71706