March 11, 2026
7:19 p.m.
Jacek Caban (@jacek) commented about include/wspiapi.h:
#ifndef _WSPIAPI_H_ #define _WSPIAPI_H_
+#ifdef __cplusplus +extern "C" { +#endif + #include <stdio.h> #include <stdlib.h> #include <string.h>
+#ifdef __cplusplus +} +#endif + This block does not make sense. In general, I think extern "C" should be placed after the includes so that it does not affect the included files. If an included file needs extern "C", it should handle that itself. It also does not really make sense to use it when there are no functions in the header, as is the case in some of your changes.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10303#note_131872