March 12, 2026
1:30 p.m.
Alfred Agrell (@Alcaro) commented about dlls/mfmediaengine/tests/mfmediaengine.c:
return; }
+ hr = CoCreateInstance(&CLSID_MFMediaEngineClassFactory, NULL, CLSCTX_INPROC_SERVER, &IID_IMFMediaEngineClassFactoryEx, + (void **)&factory_ex); + ok(hr == S_OK, "Failed to create class factory, hr %#lx.\n", hr); + hr = IMFMediaEngineClassFactoryEx_QueryInterface(factory_ex, &IID_IMFMediaEngineClassFactory, (void **)&factory2);
not gonna ok(hr==S_OK)? Not really necessary, the pointer check is gonna fail if that one isn't S_OK, but it looks kinda odd. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10305#note_131982