Re: [PATCH v6 0/5] MR10126: mf: Implement Scrubbing in SAR.

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/mf/sar.c:
> renderer->flags |= SAR_SAMPLE_REQUESTED;
>      }
>
> +    /* this is called to potentially remove the SAR_SEEKING flag */
> +    audio_renderer_get_correlated_time(renderer, NULL, NULL);
> +
>      if (FAILED(hr = MFPutWaitingWorkItem(renderer->buffer_ready_event, 0, result, &renderer->buffer_ready_key)))

I think this one is out of place, because it's only called here for a side effect. Also it's using IAudioClock::GetPosition() to reset this flag, while we use GetPosition() in render() itself, without any changes to seek flag. All of that might work, it's not easy to see if it does.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10126#note_131802