Re: [PATCH 0/8] MR6568: d3dx9: Pixel format handling changes, part 2.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/d3dx9_private.h:
> -enum format_type {
> -    FORMAT_ARGB,   /* unsigned */
> -    FORMAT_ARGBF16,/* float 16 */
> -    FORMAT_ARGBF,  /* float */
> -    FORMAT_ARGB_SNORM,
> -    FORMAT_DXT,
> -    FORMAT_INDEX,
> -    FORMAT_UNKNOWN
> +enum component_type {
> +    CTYPE_EMPTY = 0x00,
> +    CTYPE_UNORM = 0x01,
> +    CTYPE_SNORM = 0x02,
> +    CTYPE_FLOAT = 0x03,
> +    CTYPE_LUMA  = 0x04,
> +    CTYPE_INDEX = 0x05,
> +};
Purely style issues, but:
- the opening bracket should be on its own line
- no reason to use hex initializers in this non-flag/bitmask case

Also, I'm guessing you just want `CTYPE_EMPTY` to be 0, i.e. don't care for the value of the other enum constants, right? If so, I'd leave out the other initializers to show that their particular value doesn't matter.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6568#note_84091