Re: [PATCH v2 0/1] MR10342: mfmediaengine: Implement scrubbing.

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/mfmediaengine/main.c:
> +                {
> +                    /* Start playback with rate at 0.0 */
> +                    media_engine_start_playback(engine);
> +                }
> +                else
> +                {
> +                    /* Scrubbing is complete */
> +                    media_engine_set_flag(engine, FLAGS_ENGINE_SCRUBBING, FALSE);
> +                    if (engine->flags & FLAGS_ENGINE_PLAY_PENDING)
> +                        media_engine_start_playback(engine);
> +                }
> +            }
> +            LeaveCriticalSection(&engine->cs);
> +            break;
> +
> +        case MESessionScrubSampleComplete:
> I think comment is misleading a bit. RateChanged with rate != 0.0 does not always mean scrubbing was completed, right? We should of course still reset the flag regardless of the reason.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10342#note_132336