March 16, 2026
3:43 a.m.
On Mon Mar 16 08:12:55 2026 +0000, Nikolay Sivov wrote:
I think comment is misleading a bit. RateChanged with rate != 0.0 does not always mean scrubbing was completed, right? We should of course still reset the flag regardless of the reason. It's accurate at the moment, as `media_engine_set_rate` is only called with a non-zero value for the purposes of completing the scrub.
But even in the future, if we implement `IMFMediaEngine::SetPlaybackRate`, then we'll probably need special handling for when the `FLAGS_ENGINE_SCRUBBING` is set. So this will still likely be accurate (as the outer `if` statement is checking for the `FLAGS_ENGINE_SCRUBBING` flag). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10342#note_132339