Re: [PATCH 0/3] MR8056: d3dx9: Properly decode sub 8bpp indexed images.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/surface.c:
> +    uint8_t *unpacked_mem;
> +    uint8_t mask, shift;
> +
> +    switch (desc->format)
> +    {
> +        case D3DX_PIXEL_FORMAT_P1_UINT:
> +        case D3DX_PIXEL_FORMAT_P4_UINT:
> +            unpacked_desc = get_d3dx_pixel_format_info(D3DX_PIXEL_FORMAT_P8_UINT);
> +            break;
> +
> +        default:
> +            FIXME("Unexpected format %u.\n", desc->format);
> +            return E_NOTIMPL;
> +    }
> +
> +    unpacked_row_pitch = size->width * unpacked_desc->bytes_per_pixel;
> This kinda calls for a:
assert(unpacked_desc->block_width == 1);

Although I don't feel super strongly about it.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8056#note_104360