Nov. 12, 2023
5:52 p.m.
On Sat Nov 11 19:01:41 2023 +0000, Nikolay Sivov wrote:
It's likely left uninitialized in a few places where NOP handler is set. We probably should call full init() at relatively top level, and then make_nop() if it's reset. That depends on whether location could change in between the two. For consistency, it makes sense to require handler_idx to be set only by a number of helpers. The DXIL parser never emits `NOP`, but in some places emission is skipped by setting `handler_idx` to `NOP`. This would probably be improved if we set a bool in `sm6_parser_function_init()` instead.
-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/465#note_52082