March 25, 2026
8:59 a.m.
Akihiro Sagawa (@sgwaki) commented about dlls/kernel32/tests/path.c:
length = GetLongPathNameW(shortpath, NULL, 0); ok(length == expanded, "Expected %ld, got %ld\n", expanded, length);
+ /* Test that extended prefix is preserved in output when converting from short to long path */ + { + WCHAR short_path[MAX_PATH], long_path[MAX_PATH], ext_short_path[4 + MAX_PATH]; + DWORD short_len, long_len;
Instead of creating a new block to declare the variable, please declare it at the beginning of the function. Since these variable names can be a bit confusing, maybe consider renaming them to something like `shortname2`? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10192#note_133718